[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129294: Removed unwanted clear button while having inline clear option.
From: Aniketh Girish <anikethgireesh () gmail ! com>
Date: 2016-10-31 13:13:21
Message-ID: 20161031131321.5235.80641 () mimi ! kde ! org
[Download RAW message or body]
--===============2266924470287402033==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129294/#review100436
-----------------------------------------------------------
Ship it!
Ship It!
- Aniketh Girish
On Oct. 31, 2016, 1:13 p.m., Aniketh Girish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129294/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2016, 1:13 p.m.)
>
>
> Review request for Plasma, David Faure and Eike Hein.
>
>
> Bugs: 369377
> https://bugs.kde.org/show_bug.cgi?id=369377
>
>
> Repository: kio
>
>
> Description
> -------
>
> There was a unwanted clear button as well as a inline clear. The clear button was \
> old enough, so removed that button and the inline clear does the work.
>
> Diffs
> -----
>
> src/widgets/kurlrequesterdialog.h ea2533310fdb69bf8f4ac6bae826ea45439fdeb6
> src/widgets/kurlrequesterdialog.cpp 4c2f526fe9bbb6fbec8b94044bea8e37aa4b5204
>
> Diff: https://git.reviewboard.kde.org/r/129294/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Before removing the clear button.
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b28e7448-0b6a-4a5b-a410-ff8523596784__Before_Changes.png
> After changing the code for clear button.
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b45f8107-5c4f-4697-b1ae-7c0431259fcb__After_Changes.png
>
>
> Thanks,
>
> Aniketh Girish
>
>
--===============2266924470287402033==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129294/">https://git.reviewboard.kde.org/r/129294/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aniketh Girish</p>
<br />
<p>On October 31st, 2016, 1:13 p.m. UTC, Aniketh Girish wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Faure and Eike Hein.</div>
<div>By Aniketh Girish.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2016, 1:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=369377">369377</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There was a unwanted clear button as well as a inline \
clear. The clear button was old enough, so removed that button and the inline clear \
does the work.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kurlrequesterdialog.h <span style="color: \
grey">(ea2533310fdb69bf8f4ac6bae826ea45439fdeb6)</span></li>
<li>src/widgets/kurlrequesterdialog.cpp <span style="color: \
grey">(4c2f526fe9bbb6fbec8b94044bea8e37aa4b5204)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129294/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b28e7448-0b6a-4a5b-a410-ff8523596784__Before_Changes.png">Before \
removing the clear button.</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b45f8107-5c4f-4697-b1ae-7c0431259fcb__After_Changes.png">After \
changing the code for clear button.</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2266924470287402033==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic