--===============5240097879838623514== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/ ----------------------------------------------------------- (Updated Oct. 31, 2016, 1:02 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit 18776a603499ff1c6874e0c8aa6b9e44e2f1bdc7 by Aleix Pol to branch master. Repository: kpackage Description ------- The only place KConfig was used was an unused function: `QVariantMap convert(const QString &src)` Diffs ----- CMakeLists.txt 83bb9a4 autotests/CMakeLists.txt ca839ce autotests/packagestructuretest.cpp 565c7f4 autotests/querytest.cpp 403364f src/kpackage/CMakeLists.txt f6668c7 src/kpackage/package.cpp c139031 src/kpackage/packageloader.cpp 264f238 src/kpackage/private/packagejobthread.cpp ec41cdd src/kpackage/private/packages.cpp 0024058 src/kpackagetool/CMakeLists.txt 4977571 src/kpackagetool/kpackagetool.cpp e98bbe0 Diff: https://git.reviewboard.kde.org/r/129296/diff/ Testing ------- Compiles, tests still pass, everything makes sense. Thanks, Aleix Pol Gonzalez --===============5240097879838623514== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129296/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.
By Aleix Pol Gonzalez.

Updated Oct. 31, 2016, 1:02 p.m.

Changes

Submitted with commit 18776a603499ff1c6874e0c8aa6b9e44e2f1bdc7 by Aleix Pol to branch master.
Repository: kpackage

Description 

The only place KConfig was used was an unused function: QVariantMap convert(const QString &src)

Testing 

Compiles, tests still pass, everything makes sense.

Diffs

  • CMakeLists.txt (83bb9a4)
  • autotests/CMakeLists.txt (ca839ce)
  • autotests/packagestructuretest.cpp (565c7f4)
  • autotests/querytest.cpp (403364f)
  • src/kpackage/CMakeLists.txt (f6668c7)
  • src/kpackage/package.cpp (c139031)
  • src/kpackage/packageloader.cpp (264f238)
  • src/kpackage/private/packagejobthread.cpp (ec41cdd)
  • src/kpackage/private/packages.cpp (0024058)
  • src/kpackagetool/CMakeLists.txt (4977571)
  • src/kpackagetool/kpackagetool.cpp (e98bbe0)

View Diff
--===============5240097879838623514==--