[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129103: Generate metadata.json file at build time
From: Aleix Pol Gonzalez <aleixpol () kde ! org>
Date: 2016-10-31 11:10:55
Message-ID: 20161031111055.5235.79883 () mimi ! kde ! org
[Download RAW message or body]
--===============1900534607664701108==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129103/
-----------------------------------------------------------
(Updated Oct. 31, 2016, 11:10 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit 5ce8fe3462c2d40dcf8dea07bb760f918289df7c by Aleix Pol to branch \
master.
Repository: kpackage
Description
-------
In plasma-framework internally we use a QJsonObject for reading the metadata. \
Providing the metadata in desktop only makes the system have to parse \
metadata.desktop and then convert it internally into a QJsonObject. Furthermore, to \
do so we use a desktop file parser that is not very performant (at least in \
comparison to KConfig's).
As part of #129102, we made sure that plasma supports `metadata.json`. This patch \
leverages it moving the weight of converting desktop to json at compile time.
It could even make sense to convert to binary json as well, I wonder whether that \
would improve at all.
Diffs
-----
KF5PackageMacros.cmake 335fc81
Diff: https://git.reviewboard.kde.org/r/129103/diff/
Testing
-------
Ran RR 129102 without any metdata.desktop files on my system.
Nope, hold the ship its, still needs work.
Thanks,
Aleix Pol Gonzalez
--===============1900534607664701108==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129103/">https://git.reviewboard.kde.org/r/129103/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2016, 11:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5ce8fe3462c2d40dcf8dea07bb760f918289df7c by Aleix \
Pol to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In plasma-framework internally we use a QJsonObject \
for reading the metadata. Providing the metadata in desktop only makes the system \
have to parse metadata.desktop and then convert it internally into a QJsonObject. \
Furthermore, to do so we use a desktop file parser that is not very performant (at \
least in comparison to KConfig's).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">As part of #129102, we \
made sure that plasma supports <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">metadata.json</code>. This patch leverages it moving the weight of \
converting desktop to json at compile time.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It could even make \
sense to convert to binary json as well, I wonder whether that would improve at \
all.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran RR 129102 without any metdata.desktop files on my \
system.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nope, hold the ship its, still needs work.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5PackageMacros.cmake <span style="color: grey">(335fc81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129103/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1900534607664701108==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic