[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 129276: Make sure we're looking both for json and desktop metadata
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-10-31 11:06:49
Message-ID: 20161031110649.5235.30927 () mimi ! kde ! org
[Download RAW message or body]

--===============4532505279084000548==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129276/
-----------------------------------------------------------

(Updated Oct. 31, 2016, 11:06 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit dbf2bfb7b84b53aa531ff435467dd06dcc6787b6 by Aleix Pol to branch \
master.


Repository: plasma-workspace


Description
-------

We shouldn't assume metadata is in metadata.desktop


Diffs
-----

  shell/containmentconfigview.cpp 4c9d146 
  shell/scripting/scriptengine_v1.cpp 23cb839 
  wallpapers/image/backgroundlistmodel.cpp b30d86d 
  wallpapers/image/image.cpp 0a65b7d 

Diff: https://git.reviewboard.kde.org/r/129276/diff/


Testing
-------

Tests pass, all plasma desktop loads properly, even if I remove \
`.config/plasma-org.kde.plasma.desktop-appletsrc`


Thanks,

Aleix Pol Gonzalez


--===============4532505279084000548==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129276/">https://git.reviewboard.kde.org/r/129276/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated Oct. 31, 2016, 11:06 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit dbf2bfb7b84b53aa531ff435467dd06dcc6787b6 by Aleix \
Pol to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We shouldn't assume metadata is in \
metadata.desktop</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests pass, all plasma desktop loads properly, even if \
I remove <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: \
inherit;">.config/plasma-org.kde.plasma.desktop-appletsrc</code></p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/containmentconfigview.cpp <span style="color: grey">(4c9d146)</span></li>

 <li>shell/scripting/scriptengine_v1.cpp <span style="color: \
grey">(23cb839)</span></li>

 <li>wallpapers/image/backgroundlistmodel.cpp <span style="color: \
grey">(b30d86d)</span></li>

 <li>wallpapers/image/image.cpp <span style="color: grey">(0a65b7d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129276/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4532505279084000548==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic