[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Request, 99 lines] D3211: Ensure that all Effects honour the grab roles correctly
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-10-31 10:29:08
Message-ID: differential-rev-PHID-DREV-46xyrhujnjnobxvjwstk-req () phabricator ! kde ! org
[Download RAW message or body]
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, broulik.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When windows get added some effects grab the window and want to be the
only one animating this window. For this the grab roles exists. An
effect being notified later on evaluates the grab state and does not
start the animation.
This process failed due to being dependent on the order the effects are
loaded. Window Added/Closed are signals emitted by EffectsHandler, thus
first come, first serve. The requested effect order does not play into
it.
Due to that it could happen that an Effect which should not animate,
started to animate as the grab was still there.
This change adds the possibility to be notified whenever the window data
changes. A new signal is added to EffectsHandler which is emitted
whenever the windowData changes. The interested effects connect to it
and cancel their (just started) animation for the window.
Adjusted effects are:
- ScaleIn
- Fade
- WobblyWindows
In case of WobblyWindows an additional logical error was fixed that the
animations were only run when an effect grabbed instead of the other way
around.
BUG: 336866
FIXED-IN: 5.8.3
REPOSITORY
rKWIN KWin
BRANCH
window-grab-add-close-honored-5.8
REVISION DETAIL
https://phabricator.kde.org/D3211
AFFECTED FILES
autotests/integration/effects/slidingpopups_test.cpp
effects.cpp
effects/fade/package/contents/code/main.js
effects/scalein/package/contents/code/main.js
effects/slidingpopups/slidingpopups.cpp
effects/wobblywindows/wobblywindows.cpp
effects/wobblywindows/wobblywindows.h
libkwineffects/kwineffects.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma, broulik.<br />Restricted Application added a project: \
KWin.<br />Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3211" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>When windows get added some effects grab the window and want \
to be the<br /> only one animating this window. For this the grab roles exists. An<br \
/> effect being notified later on evaluates the grab state and does not<br />
start the animation.</p>
<p>This process failed due to being dependent on the order the effects are<br />
loaded. Window Added/Closed are signals emitted by EffectsHandler, thus<br />
first come, first serve. The requested effect order does not play into<br />
it.</p>
<p>Due to that it could happen that an Effect which should not animate,<br />
started to animate as the grab was still there.</p>
<p>This change adds the possibility to be notified whenever the window data<br />
changes. A new signal is added to EffectsHandler which is emitted<br />
whenever the windowData changes. The interested effects connect to it<br />
and cancel their (just started) animation for the window.</p>
<p>Adjusted effects are:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">ScaleIn</li>
<li class="remarkup-list-item">Fade</li>
<li class="remarkup-list-item">WobblyWindows</li>
</ul>
<p>In case of WobblyWindows an additional logical error was fixed that the<br />
animations were only run when an effect grabbed instead of the other way<br />
around.</p>
<p>BUG: 336866<br />
FIXED-IN: 5.8.3</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>window-grab-add-close-honored-5.8</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3211" \
rel="noreferrer">https://phabricator.kde.org/D3211</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/effects/slidingpopups_test.cpp<br /> \
effects.cpp<br /> effects/fade/package/contents/code/main.js<br />
effects/scalein/package/contents/code/main.js<br />
effects/slidingpopups/slidingpopups.cpp<br />
effects/wobblywindows/wobblywindows.cpp<br />
effects/wobblywindows/wobblywindows.h<br />
libkwineffects/kwineffects.h</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, broulik<br /><strong>Cc: \
</strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic