[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 10 lines] D3209: [Notification Applet] Position dialog before showing it
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-10-30 22:18:33
Message-ID: differential-rev-PHID-DREV-f4755i6yj2droierviyy-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added reviewers: Plasma, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures the dialog gets a proper position before being shown.
  
  On Wayland notification popups are animated by the morphing popup effect and would \
fly all over the screen when shown; now they only move around in the vicinity of \
their final position, looking really nice.

TEST PLAN
  Only tested on Wayland.
  
  With all of X's quirks this overly complex code needs to be tested more. I removed \
the updateVisibility calls which I don't think are neccessary and it works just fine \
here but I don't trust X here. Will test on X soon.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3209

AFFECTED FILES
  applets/notifications/plugin/notificationshelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mck182
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, mck182.<br />broulik set the repository for this revision to rPLASMAWORKSPACE \
Plasma Workspace.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3209" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This ensures the dialog gets a proper position before being \
shown.</p>

<p>On Wayland notification popups are animated by the morphing popup effect and would \
fly all over the screen when shown; now they only move around in the vicinity of \
their final position, looking really nice.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Only tested on Wayland.</p>

<p>With all of X&#039;s quirks this overly complex code needs to be tested more. I \
removed the updateVisibility calls which I don&#039;t think are neccessary and it \
works just fine here but I don&#039;t trust X here. Will test on X \
soon.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE \
Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3209" \
rel="noreferrer">https://phabricator.kde.org/D3209</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/notifications/plugin/notificationshelper.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, mck182<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]