[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Request, 295 lines] D3204: [KSMServer] Turn user switcher into a separate binary
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: 2016-10-30 12:24:56
Message-ID: differential-rev-PHID-DREV-65yt2qkirkh3iddpw2p5-req () phabricator ! kde ! org
[Download RAW message or body]
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This follows the same approach as the logout greeter, albeit a bit simplified.
It also creates one window per screen and should fix the problems we had with its \
positioning in multi-screen setups.
TEST PLAN
Initially I just wanted to fix blur behind the greeter on wayland and then figured \
I might as well split it out to reduce the likelihood of ksmserver crashing due to \
opengl/graphics stuff
"Switch User" in kickoff, binary launched and showed the greeter, cancelling it or \
clicking in empty area would quit the greeter. Switching a session also worked. The \
window also has blur now.
The panels show up ontop of the window on Wayland but that's also the case for the \
logout greeter.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3204
AFFECTED FILES
ksmserver/CMakeLists.txt
ksmserver/config-ksmserver.h.cmake
ksmserver/server.cpp
ksmserver/switchuser-greeter/CMakeLists.txt
ksmserver/switchuser-greeter/main.cpp
ksmserver/switchuserdialog.cpp
ksmserver/switchuserdialog.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />broulik set the repository for this revision to rPLASMAWORKSPACE Plasma \
Workspace.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3204" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
follows the same approach as the logout greeter, albeit a bit simplified.<br /> It \
also creates one window per screen and should fix the problems we had with its \
positioning in multi-screen setups.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Initially I just wanted to fix blur behind the greeter on \
wayland and then figured I might as well split it out to reduce the likelihood of \
ksmserver crashing due to opengl/graphics stuff</p>
<p>"Switch User" in kickoff, binary launched and showed the greeter, \
cancelling it or clicking in empty area would quit the greeter. Switching a session \
also worked. The window also has blur now.</p>
<p>The panels show up ontop of the window on Wayland but that's also the case \
for the logout greeter.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3204" \
rel="noreferrer">https://phabricator.kde.org/D3204</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>ksmserver/CMakeLists.txt<br /> \
ksmserver/config-ksmserver.h.cmake<br /> ksmserver/server.cpp<br />
ksmserver/switchuser-greeter/CMakeLists.txt<br />
ksmserver/switchuser-greeter/main.cpp<br />
ksmserver/switchuserdialog.cpp<br />
ksmserver/switchuserdialog.h</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic