[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128956: Make KF5Baloo optional
From: Andreas Hartmetz <ahartmetz () gmail ! com>
Date: 2016-10-09 17:46:22
Message-ID: 20161009174622.14549.84030 () mimi ! kde ! org
[Download RAW message or body]
--===============3283764348697839160==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99882
-----------------------------------------------------------
Why not add logic to the runner to disable it automatically in the appropriate \
conditions? It doesn't have to be as simplistic as "there is no Baloo database at \
all". The other Andreas sort of suggested that and dismissed it right away but I \
think it's a good idea. For example, it could be tri-state: Disabled by default if \
Baloo file search is disabled, enabled if file search is enabled, or explicitly \
enabled / disabled. While it's ugly, it also covers the case that somebody uses only \
E-mail indexing. E-mail indexing is super useful IME, and somebody might want to use \
it from krunner. I just use it from KMail, though... One could also add an option to \
the Baloo KCM to clear the file index, which would automatically disable the runner \
(not sure if this is doable with a small amount of work / code). I don't think it is \
a good idea to effectively make distributions choose Baloo support or not in krunner. \
If they still really want to, they can probably use the cascading feature of KConfig \
and supply a global config file that disables the Baloo runner by default.
- Andreas Hartmetz
On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2016, 12:06 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
>
> Regardless of the current state of Baloo, it is not very deeply tied into Plasma. \
> Usage in plasma-workspace comes down to providing the baloo runner.
>
> Diffs
> -----
>
> CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e
> runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317
>
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
>
>
> Testing
> -------
>
> Several days of Plasma-5 without any issues. Usage of krunner without any \
> segfaults.
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============3283764348697839160==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128956/">https://git.reviewboard.kde.org/r/128956/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
not add logic to the runner to disable it automatically in the appropriate \
conditions? It doesn't have to be as simplistic as "there is no Baloo database at \
all". The other Andreas sort of suggested that and dismissed it right away but I \
think it's a good idea. For example, it could be tri-state: Disabled by default if \
Baloo file search is disabled, enabled if file search is enabled, or explicitly \
enabled / disabled. While it's ugly, it also covers the case that somebody uses only \
E-mail indexing. E-mail indexing is super useful IME, and somebody might want to use \
it from krunner. I just use it from KMail, though... One could also add an option to \
the Baloo KCM to clear the file index, which would automatically disable the runner \
(not sure if this is doable with a small amount of work / code). I don't think it is \
a good idea to effectively make distributions choose Baloo support or not in krunner. \
If they still really want to, they can probably use the cascading feature of KConfig \
and supply a global config file that disables the Baloo runner by default.</p></pre> \
<br />
<p>- Andreas Hartmetz</p>
<br />
<p>On September 20th, 2016, 12:06 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2016, 12:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regardless of the current state of Baloo, it is not \
very deeply tied into Plasma. Usage in plasma-workspace comes down to providing the \
baloo runner.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Several days of Plasma-5 without any issues. Usage of \
krunner without any segfaults.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(9da918358bd797b8fe00de646b6576ba22976d0e)</span></li>
<li>runners/CMakeLists.txt <span style="color: \
grey">(48cc3799f834a57031ae387a35f41859178fe317)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128956/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3283764348697839160==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic