From kde-panel-devel Fri Oct 07 17:03:36 2016 From: Antonio Larrosa Jimenez Date: Fri, 07 Oct 2016 17:03:36 +0000 To: kde-panel-devel Subject: Re: Review Request 129118: Remove discovery associated to a key when removing a definition Message-Id: <20161007170336.11463.6910 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147585983707619 --===============2226943012436375296== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/ ----------------------------------------------------------- (Updated Oct. 7, 2016, 5:03 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kpackage Description ------- Plasmashell was calling Package::removeDefinition but a later call to Package::filePath still returned a value because there was an entry in d->discoveries but no way to remove it, which made plasma use old values. Diffs ----- src/kpackage/package.cpp 363a67ed5b7c592aea4845b84ca05e63da05991a Diff: https://git.reviewboard.kde.org/r/129118/diff/ Testing ------- I gdb'd a patched plasmashell (1) to fix a wallpaper aspect ratio problem while changing the screen resolution between 1024x768 and 1280x720 and tracing Image::findPreferedImageInPackage . package.filePath("preferred") is not empty at the beginning of the method even if package.removeDefinition("preferred") was just called, so it seems the key should be removed from d->discoveries too. (1) The plasma patch is at https://phabricator.kde.org/D2981 Thanks, Antonio Larrosa Jimenez --===============2226943012436375296== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.
By Antonio Larrosa Jimenez.

Updated Oct. 7, 2016, 5:03 p.m.

Repository: kpackage

Description 

Plasmashell was calling Package::removeDefinition but a later call to
Package::filePath still returned a value because there was an entry in
d->discoveries but no way to remove it, which made plasma use old
values.

Testing 

I gdb'd a patched plasmashell (1) to fix a wallpaper aspect ratio problem
while changing the screen resolution between 1024x768 and 1280x720
and tracing Image::findPreferedImageInPackage . 


package.filePath("preferred") is not empty at the beginning of the method
even if package.removeDefinition("preferred") was just called, so it seems
the key should be removed from d->discoveries too.


(1) The plasma patch is at https://phabricator.kde.org/D2981

Diffs

  • src/kpackage/package.cpp (363a67ed5b7c592aea4845b84ca05e63da05991a)

View Diff
--===============2226943012436375296==--