[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129118: Remove discovery associated to a key when removing a definition
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2016-10-07 16:18:07
Message-ID: 20161007161807.11463.63115 () mimi ! kde ! org
[Download RAW message or body]
--===============4145105614606409758==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129118/#review99839
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On Oct. 7, 2016, 4:10 p.m., Antonio Larrosa Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129118/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2016, 4:10 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> Plasmashell was calling Package::removeDefinition but a later call to
> Package::filePath still returned a value because there was an entry in
> d->discoveries but no way to remove it, which made plasma use old
> values.
>
>
> Diffs
> -----
>
> src/kpackage/package.cpp 363a67ed5b7c592aea4845b84ca05e63da05991a
>
> Diff: https://git.reviewboard.kde.org/r/129118/diff/
>
>
> Testing
> -------
>
> I gdb'd a patched plasmashell (1) to fix a wallpaper aspect ratio problem
> while changing the screen resolution between 1024x768 and 1280x720
> and tracing Image::findPreferedImageInPackage .
>
> package.filePath("preferred") is not empty at the beginning of the method
> even if package.removeDefinition("preferred") was just called, so it seems
> the key should be removed from d->discoveries too.
>
> (1) Plasma patch is comming to phabricator in the next minutes.
>
>
> Thanks,
>
> Antonio Larrosa Jimenez
>
>
--===============4145105614606409758==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129118/">https://git.reviewboard.kde.org/r/129118/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Sebastian Kügler</p>
<br />
<p>On October 7th, 2016, 4:10 p.m. UTC, Antonio Larrosa Jimenez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Antonio Larrosa Jimenez.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2016, 4:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Plasmashell was calling Package::removeDefinition but \
a later call to Package::filePath still returned a value because there was an entry \
in d->discoveries but no way to remove it, which made plasma use old
values.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I gdb'd a patched plasmashell (1) to fix a wallpaper \
aspect ratio problem while changing the screen resolution between 1024x768 and \
1280x720 and tracing Image::findPreferedImageInPackage . </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">package.filePath("preferred") is not empty at the \
beginning of the method even if package.removeDefinition("preferred") was just \
called, so it seems the key should be removed from d->discoveries too.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(1) Plasma patch is comming to phabricator in the next \
minutes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kpackage/package.cpp <span style="color: \
grey">(363a67ed5b7c592aea4845b84ca05e63da05991a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129118/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4145105614606409758==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic