[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2913: Make the background of the logout screen darker
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-10-03 9:52:58
Message-ID: 20161003095257.21187.38505.61112BAE () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> Logout.qml:61
> 
> +    Rectangle {
> +        color: PlasmaCore.ColorScope.backgroundColor

making the background darker makes sense.
But you already have a translucent black Rectangle at line 83, no need to add another \
one, just tweak opacity of that one (no more than ~0.75 tough)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2913

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: mart, davidedmundson, plasma-devel, apol, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2913" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2913#inline-11297" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">Logout.qml:61</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">    <span style="color: #004012">Rectangle</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">        <span style="color: #aa4000">color:</span> <span style="color: \
#004012">PlasmaCore</span><span class="p">.</span><span style="color: \
#004012">ColorScope</span><span class="p">.</span><span style="color: \
#004012">backgroundColor</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">making the background darker makes sense.<br /> But you already have a \
translucent black Rectangle at line 83, no need to add another one, just tweak \
opacity of that one (no more than ~0.75 tough)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2913" \
rel="noreferrer">https://phabricator.kde.org/D2913</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>jsalatas, Plasma, Plasma: Design<br /><strong>Cc: \
</strong>mart, davidedmundson, plasma-devel, apol, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]