[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 5 lines] D2901: Constrain kickoff config button label size
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-09-30 21:26:46
Message-ID: differential-rev-PHID-DREV-cqczilpw72xxav4tpdfg-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
davidedmundson added a subscriber: jsalatas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A better way to achieve center aligning is to use the alignment property
  of QtQuick.Text.
  
  This looks the same but because we now have left and right anchors text
  gets elided properly rather than overflowing out the box.

TEST PLAN
  Opened, looks identical

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2901

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: jsalatas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />davidedmundson added a subscriber: jsalatas.<br \
/>Restricted Application added a project: Plasma.<br />Restricted Application added a \
subscriber: plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2901" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>A better \
way to achieve center aligning is to use the alignment property<br /> of \
QtQuick.Text.</p>

<p>This looks the same but because we now have left and right anchors text<br />
gets elided properly rather than overflowing out the box.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Opened, looks identical</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2901" \
rel="noreferrer">https://phabricator.kde.org/D2901</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>jsalatas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]