[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 57 lines] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration b
From:       "jsalatas (John Salatas)" <noreply () phabricator ! kde ! org>
Date:       2016-09-30 20:57:23
Message-ID: differential-rev-PHID-DREV-jgwjum6xhav2d2tvwtla-req () phabricator ! kde ! org
[Download RAW message or body]

jsalatas created this revision.
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures we don't end up with a white icon (dark Plasma theme) on a light gray \
(default application colors) background. It also makes the configuration (draggable) \
buttons look more like a live preview.  
  similar to: https://phabricator.kde.org/D2884

TEST PLAN
  Breeze dark application scheme, Breeze dark Plasma theme
  F346143: bb.png <https://phabricator.kde.org/F346143>
  Breeze dark application scheme, Breeze light Plasma theme
  F346138: bw.png <https://phabricator.kde.org/F346138>
  Breeze light application scheme, Breeze light Plasma theme
  F346139: ww.png <https://phabricator.kde.org/F346139>
  Breeze light application scheme, Breeze dark Plasma theme
  F346142: wb.png <https://phabricator.kde.org/F346142>

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2900

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">jsalatas created this revision.<br />jsalatas added a \
reviewer: Plasma.<br />jsalatas set the repository for this revision to \
rPLASMADESKTOP Plasma Desktop.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2900" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This ensures we don&#039;t end up with a white icon (dark \
Plasma theme) on a light gray (default application colors) background. It also makes \
the configuration (draggable) buttons look more like a live preview.</p>

<p>similar to: <a href="https://phabricator.kde.org/D2884" class="remarkup-link" \
target="_blank" rel="noreferrer">https://phabricator.kde.org/D2884</a></p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Breeze dark application scheme, Breeze dark \
Plasma theme<br /> <a href="https://phabricator.kde.org/F346143" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F346143: \
bb.png</a><br /> Breeze dark application scheme, Breeze light Plasma theme<br />
<a href="https://phabricator.kde.org/F346138" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F346138: \
bw.png</a><br /> Breeze light application scheme, Breeze light Plasma theme<br />
<a href="https://phabricator.kde.org/F346139" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F346139: \
ww.png</a><br /> Breeze light application scheme, Breeze dark Plasma theme<br />
<a href="https://phabricator.kde.org/F346142" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F346142: \
wb.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2900" \
rel="noreferrer">https://phabricator.kde.org/D2900</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>jsalatas, Plasma<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic