[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 6 lines] D2887: Fix kcminit phase 1 and 2
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-09-29 19:51:03
Message-ID: differential-rev-PHID-DREV-2kfrvgrkvvktfolen65n-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current code registers the session bus *after* app->exec() this
  effectively means it won't work.
  
  This causes ksmserver to be unable to deliver the calls to start kcminit
  modules at remaining init phases.
  
  Any KCMinit module which are at X-KDE-Init-Phase=1 or 2 will now get
  run. It also means kcminit_startup closes, instead of lingersing on
  startup doing nothing until it times out 5 minutes later.

TEST PLAN
  Confirmed kcminit_startup now exits properly.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2887

AFFECTED FILES
  startkde/kcminit/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2887" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>The current code registers the session bus *after* \
app-&gt;exec() this<br /> effectively means it won&#039;t work.</p>

<p>This causes ksmserver to be unable to deliver the calls to start kcminit<br />
modules at remaining init phases.</p>

<p>Any KCMinit module which are at X-KDE-Init-Phase=1 or 2 will now get<br />
run. It also means kcminit_startup closes, instead of lingersing on<br />
startup doing nothing until it times out 5 minutes later.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Confirmed kcminit_startup now exits \
properly.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2887" \
rel="noreferrer">https://phabricator.kde.org/D2887</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>startkde/kcminit/main.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]