[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated] D2886: Fixing loading for the wallpaper thumbnails in the activity switcher
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-09-29 11:55:01
Message-ID: 20160929115501.85654.11013.129B49E0 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D2886#53635, @ivan wrote:
  
  > Note: It still does reparseConfiguration() - it does not work as expected \
otherwise.  
  
  I'm in favor of the patch in general..
  If the file was changed by another process or somewhere else in the same not by a \
ksharedconfig i think that is expected ksharedconfig does not actually notice.  
  or.. could be possible is actually a ksharedconfig bug? maybe this could be \
autotestable in kconfig framework?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2886

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2886" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2886#53635" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D2886#53635</a>, <a \
href="https://phabricator.kde.org/p/ivan/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@ivan</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Note: It still does reparseConfiguration() - \
it does not work as expected otherwise.</p></div> </blockquote>

<p>I&#039;m in favor of the patch in general..<br />
If the file was changed by another process or somewhere else in the same not by a \
ksharedconfig i think that is expected ksharedconfig does not actually notice.</p>

<p>or.. could be possible is actually a ksharedconfig bug? maybe this could be \
autotestable in kconfig framework?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2886" \
rel="noreferrer">https://phabricator.kde.org/D2886</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ivan, Plasma, davidedmundson, mart<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]