[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D2872: use KPluginSelector to enable runners
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: 2016-09-29 10:13:05
Message-ID: 20160929101304.75748.52001.2023781C () phabricator ! kde ! org
[Download RAW message or body]
broulik added inline comments.
INLINE COMMENTS
> kcm.cpp:47
> > KCModule(parent, args)
> - , m_config(QStringLiteral("krunnerrc"))
> - , m_configGroup(m_config.group("PlasmaRunnerManager"))
> + , m_config("krunnerrc")
> {
Are you even using that still? All I see is a KSharedConfig::openConfig in load
> kcm.cpp:76
>
> - if (!runners.isEmpty()) {
> - const QRect rect = m_listWidget->visualItemRect(item);
> - m_configButton->move(QPoint(rect.right(), rect.center().y()) - \
> QPoint(m_configButton->width(), m_configButton->height()/2));
> - m_configButton->setVisible(true);
> - m_configButton->setProperty("runners", QVariant::fromValue(runners));
> - } else {
> - m_configButton->setVisible(false);
> - }
> - });
> + //overload, can't use the new syntax
> + connect(m_pluginSelector, SIGNAL(changed(bool)),
Sure you can, if you cast :)
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
phab/kpluginselector
REVISION DETAIL
https://phabricator.kde.org/D2872
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2872" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2872#inline-11213" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kcm.cpp:47</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #aa2211">:</span> <span class="n">KCModule</span><span \
class="p">(</span><span class="n">parent</span><span class="p">,</span> <span \
class="n">args</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> <span class="p">,</span> <span \
class="n">m_config</span><span class="p">(<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span style="color: \
#766510">"krunnerrc"<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span>)</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span \
class="p">,</span> <span class="n">m_configGroup</span><span class="p">(</span><span \
class="n">m_config</span><span class="p">.</span><span class="n">group</span><span \
class="p">(</span><span style="color: \
#766510">"PlasmaRunnerManager"</span><span class="p">))</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="p">,</span> <span class="n">m_config</span><span class="p">(</span><span \
style="color: #766510">"krunnerrc"</span><span class="p">)</span> \
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Are you even using that still? All I see is a KSharedConfig::openConfig \
in load</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2872#inline-11212" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kcm.cpp:76</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;"> <span class="bright"></span><span class="n"><span \
class="bright">m_configButton</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span style="color: #aa4000"><span class="bright">new</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QToolButton</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">m_listWidget</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">viewport</span></span><span class="bright"></span><span \
class="p"><span class="bright">());</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span \
class="n"><span class="bright">m_configButton</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">setIcon</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">QIcon</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">::</span></span><span class="bright"></span><span \
class="n"><span class="bright">fromTheme</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span class="bright">"configure"</span></span><span \
class="bright"></span><span class="p"><span class="bright">)));</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="bright"></span><span style="color: #74777d"><span class="bright">//overload, \
can't use the new syntax</span></span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span \
class="bright">connect</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">m_pluginSelector</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
class="n"><span class="bright">SIGNAL</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">changed</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #aa4000"><span class="bright">bool</span></span><span \
class="bright"></span><span class="p"><span class="bright">)),</span></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Sure you can, if you cast :)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>phab/kpluginselector</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2872" \
rel="noreferrer">https://phabricator.kde.org/D2872</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic