[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129058: [corona] Sync config immidiately when it's dirty
From: Marco Martin <notmart () gmail ! com>
Date: 2016-09-28 17:16:56
Message-ID: 20160928171656.14576.61522 () mimi ! kde ! org
[Download RAW message or body]
--===============4832327204184482261==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 28, 2016, 10:12 a.m., Marco Martin wrote:
> > all thisdoes is causing more disk access, making things slower
>
> Anthony Fieroni wrote:
> More disk access, maybe, but slower, how can be?
>
> Aleix Pol Gonzalez wrote:
> Why more disk access?
> At least this won't be emitting configChanged if it was dirty and was a no-op sync.
>
> David Edmundson wrote:
> because there's more disk access.
>
> Turning this question around: how can yours be faster? - nothing is blocked waiting \
> on the file to be written - so making that happen sooner won't speed anything up
> Anthony Fieroni wrote:
> Yes it is. Waiting 10 sec is never be faster. Even i wait more than 20 sec because \
> timer is scheduled twice. On SSD, i have boot time 3 sec, KDE splash > 20 sec.
> David Edmundson wrote:
> But KSplash is not waiting for this timer to finish. Making that comment completely \
> unrelated.
> The bootup starts, the bootup finishes - later this timer causes us to save some \
> things.
> Nothing is waiting for this save to happen - so nothing will be faster if you make \
> it happen earlier.
> Marco Martin wrote:
> it's not waiting on this timer in order to start
>
> Anthony Fieroni wrote:
> Still can't find who to blame for this slow starting?
mostly, creating qml objects
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129058/#review99612
-----------------------------------------------------------
On Sept. 28, 2016, 10:44 a.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129058/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 10:44 a.m.)
>
>
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This patch trys to minimize loading time of plasmashell, especially annoying \
> waiting at splash screen.
>
> Diffs
> -----
>
> src/plasma/corona.h 07ad284
> src/plasma/corona.cpp 7ff64cd
> src/plasma/private/corona_p.h d556baf
>
> Diff: https://git.reviewboard.kde.org/r/129058/diff/
>
>
> Testing
> -------
>
> Seems good but it may have downsides?
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============4832327204184482261==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129058/">https://git.reviewboard.kde.org/r/129058/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 28th, 2016, 10:12 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">all thisdoes is causing more disk access, making \
things slower</p></pre> </blockquote>
<p>On September 28th, 2016, 10:30 a.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">More \
disk access, maybe, but slower, how can be?</p></pre> </blockquote>
<p>On September 28th, 2016, 10:36 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
more disk access? At least this won't be emitting configChanged if it was dirty and \
was a no-op sync.</p></pre> </blockquote>
<p>On September 28th, 2016, 10:36 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">because there's more disk access.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Turning this question \
around: how can yours be faster? - nothing is blocked waiting on the file to be \
written - so making that happen sooner won't speed anything up</p></pre> \
</blockquote>
<p>On September 28th, 2016, 10:39 a.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes \
it is. Waiting 10 sec is never be faster. Even i wait more than 20 sec because timer \
is scheduled twice. On SSD, i have boot time 3 sec, KDE splash > 20 sec.</p></pre> \
</blockquote>
<p>On September 28th, 2016, 10:56 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
KSplash is not waiting for this timer to finish. Making that comment completely \
unrelated.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The bootup starts, the bootup finishes - later this \
timer causes us to save some things.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Nothing is waiting for \
this save to happen - so nothing will be faster if you make it happen \
earlier.</p></pre> </blockquote>
<p>On September 28th, 2016, 11:25 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's \
not waiting on this timer in order to start</p></pre> </blockquote>
<p>On September 28th, 2016, 5:04 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Still \
can't find who to blame for this slow starting?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">mostly, creating qml objects</p></pre> <br />
<p>- Marco</p>
<br />
<p>On September 28th, 2016, 10:44 a.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2016, 10:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch trys to minimize loading time of \
plasmashell, especially annoying waiting at splash screen.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems good but it may have downsides?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/corona.h <span style="color: grey">(07ad284)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(7ff64cd)</span></li>
<li>src/plasma/private/corona_p.h <span style="color: grey">(d556baf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129058/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4832327204184482261==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic