[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 106911: ksmserver should ignore non-executable files under ~/.kde4/Autostart
From: Jekyll Wu <adaptee () gmail ! com>
Date: 2016-09-24 10:04:36
Message-ID: 20160924100436.10493.96455 () mimi ! kde ! org
[Download RAW message or body]
--===============2277512140927264518==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106911/
-----------------------------------------------------------
(Updated Sept. 24, 2016, 10:04 a.m.)
Status
------
This change has been discarded.
Review request for Plasma and Luboš Luňák.
Bugs: 286658
http://bugs.kde.org/show_bug.cgi?id=286658
Repository: kde-workspace
Description
-------
It does not make sense to feed non-executable files to krun, since that folder is \
named as "Autostart", which expects executable files.
Those .desktop files might be exception to the above rule, but I don't know whether \
the current situation of supporting .desktop under ~/.kde4/Autostart is an \
intentional or incidental feature.
Diffs
-----
ksmserver/startup.cpp d99ce4c
Diff: https://git.reviewboard.kde.org/r/106911/diff/
Testing
-------
Thanks,
Jekyll Wu
--===============2277512140927264518==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/106911/">https://git.reviewboard.kde.org/r/106911/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Luboš Luňák.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2016, 10:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=286658">286658</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It does not make sense to feed non-executable files to krun, since that \
folder is named as "Autostart", which expects executable files.
Those .desktop files might be exception to the above rule, but I don't know \
whether the current situation of supporting .desktop under ~/.kde4/Autostart is an \
intentional or incidental feature.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/startup.cpp <span style="color: grey">(d99ce4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/106911/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2277512140927264518==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic