[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist
From: José_Manuel_Santamaría_Lema <panfaust () gmail ! com>
Date: 2016-09-22 20:40:45
Message-ID: 20160922204045.26270.71095 () mimi ! kde ! org
[Download RAW message or body]
--===============1471234200503705051==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118865/
-----------------------------------------------------------
(Updated Sept. 22, 2016, 8:40 p.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Hi,
I have been working a bit in kubuntu's plasma packaging, when I started plasma from a \
fresh new account I noticed I couldn't see most icons in the GUI's except for a few \
ones.
So I checked the starkde output to try to find out what was wrong, I found a line \
like this one: static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to \
determine KDEHOME
Digging a bit more into the issue I also found out where this message comes from.
File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0) lines \
446-468: QPlatformTheme *QKdeTheme::createKdeTheme()
{
// Check for version >= 4 and determine home folder from environment,
// defaulting to ~/.kde<version>, ~/.kde
const QByteArray kdeVersionBA = qgetenv("KDE_SESSION_VERSION");
const int kdeVersion = kdeVersionBA.toInt();
if (kdeVersion < 4)
return 0;
const QString kdeHomePathVar = QString::fromLocal8Bit(qgetenv("KDEHOME"));
if (!kdeHomePathVar.isEmpty())
return new QKdeTheme(kdeHomePathVar, kdeVersion);
const QString kdeVersionHomePath = QDir::homePath() + QStringLiteral("/.kde") + \
QLatin1String(kdeVersionBA); if (QFileInfo(kdeVersionHomePath).isDir())
return new QKdeTheme(kdeVersionHomePath, kdeVersion);
const QString kdeHomePath = QDir::homePath() + QStringLiteral("/.kde");
if (QFileInfo(kdeHomePath).isDir())
return new QKdeTheme(kdeHomePath, kdeVersion);
qWarning("%s: Unable to determine KDEHOME", Q_FUNC_INFO);
return 0;
}
So I'm inclined to think the ~/.kde directory should be created if it doesn't exist, \
thats what the patch does. What do you think?
Diffs
-----
startkde/startkde.cmake ea0bdfe
Diff: https://git.reviewboard.kde.org/r/118865/diff/
Testing
-------
Applied a similar patch in a customized kubuntu package. With the patch the ~/.kde \
directory is created and the icons can be seen.
Thanks,
José Manuel Santamaría Lema
--===============1471234200503705051==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118865/">https://git.reviewboard.kde.org/r/118865/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2016, 8:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
I have been working a bit in kubuntu's plasma packaging, when I started plasma \
from a fresh new account I noticed I couldn't see most icons in the GUI's \
except for a few ones.
So I checked the starkde output to try to find out what was wrong, I found a line \
like this one: static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to \
determine KDEHOME
Digging a bit more into the issue I also found out where this message comes from.
File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0) lines \
446-468: QPlatformTheme *QKdeTheme::createKdeTheme()
{
// Check for version >= 4 and determine home folder from environment,
// defaulting to ~/.kde<version>, ~/.kde
const QByteArray kdeVersionBA = qgetenv("KDE_SESSION_VERSION");
const int kdeVersion = kdeVersionBA.toInt();
if (kdeVersion < 4)
return 0;
const QString kdeHomePathVar = \
QString::fromLocal8Bit(qgetenv("KDEHOME")); if (!kdeHomePathVar.isEmpty())
return new QKdeTheme(kdeHomePathVar, kdeVersion);
const QString kdeVersionHomePath = QDir::homePath() + \
QStringLiteral("/.kde") + QLatin1String(kdeVersionBA); if \
(QFileInfo(kdeVersionHomePath).isDir()) return new QKdeTheme(kdeVersionHomePath, \
kdeVersion);
const QString kdeHomePath = QDir::homePath() + \
QStringLiteral("/.kde"); if (QFileInfo(kdeHomePath).isDir())
return new QKdeTheme(kdeHomePath, kdeVersion);
qWarning("%s: Unable to determine KDEHOME", Q_FUNC_INFO);
return 0;
}
So I'm inclined to think the ~/.kde directory should be created if it doesn't \
exist, thats what the patch does. What do you think? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applied a similar patch in a customized kubuntu package. With the patch \
the ~/.kde directory is created and the icons can be seen.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/startkde.cmake <span style="color: grey">(ea0bdfe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118865/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1471234200503705051==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic