'Re: Review Request 115162: Launch single instance of plasma-mediacenter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115162: Launch single instance of plasma-mediacenter
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-09-22 20:37:18
Message-ID: 20160922203718.26270.66139 () mimi ! kde ! org
[Download RAW message or body]

--===============1350939192357550720==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/#review99460
-----------------------------------------------------------



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On Jan. 22, 2014, 6:38 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115162/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 6:38 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Launching single instance of plasma-mediacenter. Using KUniqueApplication only \
> single instance of plasma-mediacenter is launched. 
> 
> Diffs
> -----
> 
> shells/newshell/CMakeLists.txt 60949df 
> shells/newshell/application.h PRE-CREATION 
> shells/newshell/application.cpp PRE-CREATION 
> shells/newshell/main.cpp 9fd5df3 
> shells/newshell/mainwindow.h 5e0753e 
> shells/newshell/mainwindow.cpp 1bf56ac 
> shells/newshell/plasma-mediacenter.desktop c3c5781 
> 
> Diff: https://git.reviewboard.kde.org/r/115162/diff/
> 
> 
> Testing
> -------
> 
> Tests done using konsole:
> a) Open a tab and launch pmc.
> b) Open another tab and try to launch another instance of pmc.
> c) After executing (b) pmc wont launch because already another instance of pmc from \
> (a) is already running. 
> Tests done using Dolphin:
> a) Go to the music folder and right click on the file to be played. Click open with \
> and launch pmc. b) Try to open another file using same step as (a)
> c) After executing (b) wait for few seconds and you can see that only single \
> instance of (a) will be running. 
> 
> Thanks,
> 
> Sujith Haridasan
> 
> 


--===============1350939192357550720==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115162/">https://git.reviewboard.kde.org/r/115162/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Closing as this review request is more than 2 years old.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If it still applies to current Plasma please reopen this review request. \
Thanks</p></pre>  <br />









<p>- David Edmundson</p>


<br />
<p>On January 22nd, 2014, 6:38 a.m. UTC, Sujith Haridasan wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>


<p style="color: grey;"><i>Updated Jan. 22, 2014, 6:38 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Launching single instance of plasma-mediacenter. Using \
KUniqueApplication only single instance of plasma-mediacenter is launched.</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests done using konsole: a) Open a tab and launch pmc.
b) Open another tab and try to launch another instance of pmc.
c) After executing (b) pmc wont launch because already another instance of pmc from \
(a) is already running.

Tests done using Dolphin:
a) Go to the music folder and right click on the file to be played. Click open with \
and launch pmc. b) Try to open another file using same step as (a)
c) After executing (b) wait for few seconds and you can see that only single instance \
of (a) will be running.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shells/newshell/CMakeLists.txt <span style="color: grey">(60949df)</span></li>

 <li>shells/newshell/application.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>shells/newshell/application.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>shells/newshell/main.cpp <span style="color: grey">(9fd5df3)</span></li>

 <li>shells/newshell/mainwindow.h <span style="color: grey">(5e0753e)</span></li>

 <li>shells/newshell/mainwindow.cpp <span style="color: grey">(1bf56ac)</span></li>

 <li>shells/newshell/plasma-mediacenter.desktop <span style="color: \
grey">(c3c5781)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115162/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1350939192357550720==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic