[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-09-22 20:37:06
Message-ID: 20160922203706.26270.15840 () mimi ! kde ! org
[Download RAW message or body]
--===============7638985618787947198==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110122/#review99459
-----------------------------------------------------------
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On April 25, 2013, 1:58 p.m., James Pike wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110122/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 1:58 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 318295
> http://bugs.kde.org/show_bug.cgi?id=318295
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Currently the timeout of the last notification to arrive is used as a basis for \
> hiding the notification display. This means that a notification with a high timeout \
> can get hidden by a new notification arriving with a much lower timeout.
> This patch simply changes the behaviour to, when expiring a timer, go back through \
> the stack and display the most recent unexpired timer. If all timers are expired \
> the notification is closed as before.
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11
>
> Diff: https://git.reviewboard.kde.org/r/110122/diff/
>
>
> Testing
> -------
>
> Test script in https://bugs.kde.org/show_bug.cgi?id=318295
>
>
> Thanks,
>
> James Pike
>
>
--===============7638985618787947198==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110122/">https://git.reviewboard.kde.org/r/110122/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Closing as this review request is more than 2 years old.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If it still applies to current Plasma please reopen this review request. \
Thanks</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On April 25th, 2013, 1:58 p.m. UTC, James Pike wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By James Pike.</div>
<p style="color: grey;"><i>Updated April 25, 2013, 1:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318295">318295</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the timeout of the last notification to arrive is used as a \
basis for hiding the notification display. This means that a notification with a high \
timeout can get hidden by a new notification arriving with a much lower timeout.
This patch simply changes the behaviour to, when expiring a timer, go back through \
the stack and display the most recent unexpired timer. If all timers are expired the \
notification is closed as before.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test script in https://bugs.kde.org/show_bug.cgi?id=318295</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(2fa1b11)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110122/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7638985618787947198==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic