[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devi
From:       Benedikt Gollatz <benedikt () gollatz ! net>
Date:       2016-09-22 20:35:42
Message-ID: 20160922203542.26270.47324 () mimi ! kde ! org
[Download RAW message or body]

--===============9185139232978799680==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112812/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 8:35 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 324459
    http://bugs.kde.org/show_bug.cgi?id=324459


Repository: kde-workspace


Description
-------

Use type description sort order in the devicenotifier applet when non-removable \
devices are configured to be displayed. This avoids apparently random sort order (by \
device engine population timestamp) and unneccessary ListView sections. The problem \
becomes apparent if other types of devices besides simple storage volumes are \
configured in /etc/fstab, like for example network mounts.

Fixes bug #324459.


Diffs
-----

  plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
9b6132e 

Diff: https://git.reviewboard.kde.org/r/112812/diff/


Testing
-------

Works for me using KDE 4.10.5 packaged with Fedora 19.


Thanks,

Benedikt Gollatz


--===============9185139232978799680==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/112812/">https://git.reviewboard.kde.org/r/112812/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Benedikt Gollatz.</div>


<p style="color: grey;"><i>Updated Sept. 22, 2016, 8:35 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=324459">324459</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use type description sort order in the devicenotifier applet when \
non-removable devices are configured to be displayed. This avoids apparently random \
sort order (by device engine population timestamp) and unneccessary ListView \
sections. The problem becomes apparent if other types of devices besides simple \
storage volumes are configured in /etc/fstab, like for example network mounts.

Fixes bug #324459.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me using KDE 4.10.5 packaged with Fedora 19.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(9b6132e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/112812/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============9185139232978799680==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic