[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110504: Group tasks by activity
From: José Millán Soto <fid () gpul ! org>
Date: 2016-09-22 20:35:32
Message-ID: 20160922203532.26270.63687 () mimi ! kde ! org
[Download RAW message or body]
--===============5388719708899435707==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110504/
-----------------------------------------------------------
(Updated Sept. 22, 2016, 8:35 p.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: kde-workspace
Description
-------
New grouping strategy was created to allow tasks to be grouped by activity.
If an item is available in multiple activities, it will only appear in one of the \
activities the task is available on (except if it's available on all activities). \
GroupManager was modified so that whether items should be grouped just when the task \
bar is full or not is not only taken into account when grouping by program but also \
when grouping by activity. Activity icons are not handled yet, so an icon from the \
first task which was on the group is used as the icon of the task group.
Diffs
-----
libs/taskmanager/CMakeLists.txt 70fa791
libs/taskmanager/groupmanager.h ad4167a
libs/taskmanager/groupmanager.cpp 9ac15e7
libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION
libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION
plasma/desktop/applets/tasks/tasks.cpp dbbb0cb
Diff: https://git.reviewboard.kde.org/r/110504/diff/
Testing
-------
Three activities were created (named "Activity 1", "Activity 2" and "Activity 3").
One instance of KDialog was assigned to Activity 1, two instances of KDialog were \
assigned to Activity 2, three instances of KDialog were assigned to Activity 3 and \
one instance of KDialog was assigned both to Activities 2 & 3. The tasks applet was \
executed in plasma-windowed in all activities. Screenshot 1 & 2 show the task manager \
in the situation described above. Screenshot 3 shows the same task manager after \
leaving only one instance of KDialog in each activity ("Only group when taskbar is \
full" enabled), and screenshot 4 shows the task manager when the tasks are the same \
that in screenshot 3 but "Only group when taskbar is full" is disabled.
File Attachments
----------------
Screenshot 1
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png
Screenshot 2
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png
Screenshot 3
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png
Screenshot 4
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png
Thanks,
José Millán Soto
--===============5388719708899435707==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110504/">https://git.reviewboard.kde.org/r/110504/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2016, 8:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New grouping strategy was created to allow tasks to be grouped by \
activity. If an item is available in multiple activities, it will only appear in one \
of the activities the task is available on (except if it's available on all \
activities). GroupManager was modified so that whether items should be grouped just \
when the task bar is full or not is not only taken into account when grouping by \
program but also when grouping by activity. Activity icons are not handled yet, so an \
icon from the first task which was on the group is used as the icon of the task \
group.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Three activities were created (named "Activity 1", \
"Activity 2" and "Activity 3"). One instance of KDialog was \
assigned to Activity 1, two instances of KDialog were assigned to Activity 2, three \
instances of KDialog were assigned to Activity 3 and one instance of KDialog was \
assigned both to Activities 2 & 3. The tasks applet was executed in \
plasma-windowed in all activities. Screenshot 1 & 2 show the task manager in the \
situation described above. Screenshot 3 shows the same task manager after leaving \
only one instance of KDialog in each activity ("Only group when taskbar is \
full" enabled), and screenshot 4 shows the task manager when the tasks are the \
same that in screenshot 3 but "Only group when taskbar is full" is \
disabled.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/CMakeLists.txt <span style="color: grey">(70fa791)</span></li>
<li>libs/taskmanager/groupmanager.h <span style="color: grey">(ad4167a)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(9ac15e7)</span></li>
<li>libs/taskmanager/strategies/activitygroupingstrategy.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/strategies/activitygroupingstrategy.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/tasks/tasks.cpp <span style="color: \
grey">(dbbb0cb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110504/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png">Screenshot \
1</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png">Screenshot \
2</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png">Screenshot \
3</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png">Screenshot \
4</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5388719708899435707==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic