[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 102291: Trigger installation of missing components when installing a package
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-09-22 20:34:11
Message-ID: 20160922203411.25579.67636 () mimi ! kde ! org
[Download RAW message or body]
--===============8822364779473045543==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102291/#review99450
-----------------------------------------------------------
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On Aug. 10, 2011, 10:10 p.m., Kevin Kofler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/102291/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2011, 10:10 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This is another part of my GSoC 2011 work.
>
> For script engines, the existing metadata (X-Plasma-API) is sufficient.
>
> For data engines, we introduce a new metadata entry:
> X-Plasma-RequiredDataEngines. Third-party packages will have to add this entry
> to benefit from this feature at this time. Automatic support for scanning
> package source code on installation (at least for some languages) is planned,
> but the metadata entry is definitely the most efficient method.
>
>
> Diffs
> -----
>
> plasma/package.cpp 4c00d36
> plasma/packagemetadata.h b10f0e4
> plasma/packagemetadata.cpp 59163b2
>
> Diff: https://git.reviewboard.kde.org/r/102291/diff/
>
>
> Testing
> -------
>
> Verified that it compiles without errors and that it successfully prompts for a \
> missing Python script engine right after installing a Python widget (I used Veromix \
> for my test) through KHNS (not only when actually using it) on Fedora 15. Also \
> verified that there is no such prompt if plasma-scriptengine-python is already \
> installed.
> (The patch is against master (4.8), but applies without changes to the kdelibs \
> 4.6.5 in Fedora 15, which is how I tested it.)
>
> Thanks,
>
> Kevin Kofler
>
>
--===============8822364779473045543==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/102291/">https://git.reviewboard.kde.org/r/102291/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Closing as this review request is more than 2 years old.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If it still applies to current Plasma please reopen this review request. \
Thanks</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On August 10th, 2011, 10:10 p.m. UTC, Kevin Kofler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kevin Kofler.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2011, 10:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is another part of my GSoC 2011 work.
For script engines, the existing metadata (X-Plasma-API) is sufficient.
For data engines, we introduce a new metadata entry:
X-Plasma-RequiredDataEngines. Third-party packages will have to add this entry
to benefit from this feature at this time. Automatic support for scanning
package source code on installation (at least for some languages) is planned,
but the metadata entry is definitely the most efficient method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified that it compiles without errors and that it successfully \
prompts for a missing Python script engine right after installing a Python widget (I \
used Veromix for my test) through KHNS (not only when actually using it) on Fedora \
15. Also verified that there is no such prompt if plasma-scriptengine-python is \
already installed.
(The patch is against master (4.8), but applies without changes to the kdelibs 4.6.5 \
in Fedora 15, which is how I tested it.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/package.cpp <span style="color: grey">(4c00d36)</span></li>
<li>plasma/packagemetadata.h <span style="color: grey">(b10f0e4)</span></li>
<li>plasma/packagemetadata.cpp <span style="color: grey">(59163b2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/102291/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8822364779473045543==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic