From kde-panel-devel Thu Sep 22 20:33:32 2016 From: Jekyll Wu Date: Thu, 22 Sep 2016 20:33:32 +0000 To: kde-panel-devel Subject: Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match wha Message-Id: <20160922203332.26270.44250 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147457641826108 --===============6285574126326502925== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/ ----------------------------------------------------------- (Updated Sept. 22, 2016, 8:33 p.m.) Status ------ This change has been discarded. Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description ------- What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror. The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review. Diffs ----- runners/CMakeLists.txt bb4b491 runners/konquerorprofiles/CMakeLists.txt PRE-CREATION runners/konquerorprofiles/Messages.sh PRE-CREATION runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd PRE-CREATION runners/konquerorsessions/CMakeLists.txt be2ea9d runners/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: https://git.reviewboard.kde.org/r/107868/diff/ Testing ------- Thanks, Jekyll Wu --===============6285574126326502925== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/

This change has been discarded.

Review request for Plasma.
By Jekyll Wu.

Updated Sept. 22, 2016, 8:33 p.m.

Bugs: 188494
Repository: kdeplasma-addons

Description 

What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror.

The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review.

Diffs

  • runners/CMakeLists.txt (bb4b491)
  • runners/konquerorprofiles/CMakeLists.txt (PRE-CREATION)
  • runners/konquerorprofiles/Messages.sh (PRE-CREATION)
  • runners/konquerorprofiles/konquerorprofiles.cpp (PRE-CREATION)
  • runners/konquerorprofiles/konquerorprofiles.desktop (PRE-CREATION)
  • runners/konquerorprofiles/konquerorprofiles.h (PRE-CREATION)
  • runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd (PRE-CREATION)
  • runners/konquerorsessions/CMakeLists.txt (be2ea9d)
  • runners/konquerorsessions/Messages.sh (0720e1e)
  • runners/konquerorsessions/konquerorsessions.cpp (f2e437a)
  • runners/konquerorsessions/konquerorsessions.desktop (df81780)
  • runners/konquerorsessions/konquerorsessions.h (957f976)

View Diff
--===============6285574126326502925==--