[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
From: Jekyll Wu <adaptee () gmail ! com>
Date: 2016-09-22 20:33:16
Message-ID: 20160922203316.26270.23612 () mimi ! kde ! org
[Download RAW message or body]
--===============7238912294751582574==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107869/
-----------------------------------------------------------
(Updated Sept. 22, 2016, 8:33 p.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Bugs: 188494
http://bugs.kde.org/show_bug.cgi?id=188494
Repository: kdeplasma-addons
Description
-------
This is a follow-up of https://git.reviewboard.kde.org/r/107868/ .
The code is based upon the old and unreal konquerorsessions plugin, with minimal modification \
(since I'm not familiar with krunner plugins) to make it work in the way as its name implies.
The patch can't be uploaded as diff, since it depends upon the patch in \
https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached \
file below.
Diffs
-----
Diff: https://git.reviewboard.kde.org/r/107869/diff/
Testing
-------
File Attachments
----------------
the patch
https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch
Thanks,
Jekyll Wu
--===============7238912294751582574==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/107869/">https://git.reviewboard.kde.org/r/107869/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2016, 8:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=188494">188494</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a follow-up \
of https://git.reviewboard.kde.org/r/107868/ .
The code is based upon the old and unreal konquerorsessions plugin, with minimal modification \
(since I'm not familiar with krunner plugins) to make it work in the way as its name \
implies.
The patch can't be uploaded as diff, since it depends upon the patch in \
https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached \
file below.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/107869/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch">the \
patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7238912294751582574==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic