[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109124: qml port currentappcontrol
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-09-22 20:32:45
Message-ID: 20160922203245.26270.73748 () mimi ! kde ! org
[Download RAW message or body]
--===============8667289828579271708==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109124/#review99446
-----------------------------------------------------------
Closing as this review request is more than 2 years old.
If it still applies to current Plasma. Please reopen. Thanks
- David Edmundson
On Feb. 25, 2013, 6:20 p.m., Gregor Tätzner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109124/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 6:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Heya folks,
> This is a qml port of the netbook applet currentappcontrol. It's ready to use, but \
> not fully complete. Missing features/bugs:
> - If you click on the title on the task bar, it doesn't show the kwin present \
> windows effect, how to implement that? Is there interest in a 'kwin dataengine' or \
> should I go for a mixed C++/QML applet?
> - there is an annoyance in the task list(present windows fallback): I can set a \
> minimum height, but if I close a task and re-set the minimum height, the popup \
> won't shrink again, leaving an unpleasant empty space; plasma bug?
> - the close/restore buttons don't glow on hover. I couldn't load a theme svg using \
> the IconItem. Is that possible?
> - do you know how to read the size of the containment the widget is contained?
>
>
> Diffs
> -----
>
> CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857
> plasma/netbook/applets/currentappcontrol/CMakeLists.txt \
> 46178ce3a9351845855e9fccfbc13a9d3946fc95 \
> plasma/netbook/applets/currentappcontrol/Messages.sh \
> 45d44681ae1be43b2d71ca48ab3e77af37ad8861 \
> plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION \
> plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION \
> plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION
> Diff: https://git.reviewboard.kde.org/r/109124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregor Tätzner
>
>
--===============8667289828579271708==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109124/">https://git.reviewboard.kde.org/r/109124/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Closing as this review request is more than 2 years old.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If it still applies to current Plasma. Please reopen. Thanks</p></pre> <br \
/>
<p>- David Edmundson</p>
<br />
<p>On February 25th, 2013, 6:20 p.m. UTC, Gregor Tätzner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Gregor Tätzner.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2013, 6:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Heya folks, This is a qml port of the netbook applet currentappcontrol. \
It's ready to use, but not fully complete. Missing features/bugs:
- If you click on the title on the task bar, it doesn't show the kwin present \
windows effect, how to implement that? Is there interest in a 'kwin \
dataengine' or should I go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set a \
minimum height, but if I close a task and re-set the minimum height, the popup \
won't shrink again, leaving an unpleasant empty space; plasma \
bug?
- the close/restore buttons don't glow on hover. I couldn't load a theme svg \
using the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(6084d7dd7655372506e02abe9f141b73155c5857)</span></li>
<li>plasma/netbook/applets/currentappcontrol/CMakeLists.txt <span style="color: \
grey">(46178ce3a9351845855e9fccfbc13a9d3946fc95)</span></li>
<li>plasma/netbook/applets/currentappcontrol/Messages.sh <span style="color: \
grey">(45d44681ae1be43b2d71ca48ab3e77af37ad8861)</span></li>
<li>plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/netbook/applets/currentappcontrol/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109124/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8667289828579271708==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic