[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2817: better bookeeping of the config
From:       sebas_(Sebastian_Kügler) <noreply () phabricator ! kde ! org>
Date:       2016-09-20 10:55:34
Message-ID: 20160920105534.20364.50978.BD3DD43D () phabricator ! kde ! org
[Download RAW message or body]

sebas added inline comments.

INLINE COMMENTS

> systemtray.cpp:139
> +        Applet *applet = Plasma::PluginLoader::self()->loadApplet(task, \
> m_knownPlugins.value(task), QVariantList()); +        \
> applet->setProperty("org.kde.plasma:force-create", true); +        \
> addApplet(applet);

I think applet can be null here

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2817

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts


[Attachment #3 (text/html)]

<table><tr><td style="">sebas added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2817" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2817#inline-11018" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">systemtray.cpp:139</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">        <span class="n">Applet</span> <span style="color: \
#aa2211">*</span><span class="n">applet</span> <span style="color: #aa2211">=</span> \
<span class="n">Plasma</span><span style="color: #aa2211">::</span><span \
class="n">PluginLoader</span><span style="color: #aa2211">::</span><span \
class="n">self</span><span class="p">()</span><span style="color: \
#aa2211">-&gt;</span><span class="n">loadApplet</span><span class="p">(</span><span \
class="n">task</span><span class="p">,</span> <span \
class="n">m_knownPlugins</span><span class="p">.</span><span \
class="n">value</span><span class="p">(</span><span class="n">task</span><span \
class="p">),</span> <span class="n">QVariantList</span><span class="p">());</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
class="n">applet</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setProperty</span><span class="p">(</span><span style="color: \
#766510">&quot;org.kde.plasma:force-create&quot;</span><span class="p">,</span> <span \
style="color: #304a96">true</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
class="n">addApplet</span><span class="p">(</span><span class="n">applet</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
think applet can be null here</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2817" \
rel="noreferrer">https://phabricator.kde.org/D2817</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>sebas, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]