[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default
From: Leslie Zhai <xiangzhai83 () gmail ! com>
Date: 2016-09-18 3:01:10
Message-ID: 20160918030110.8978.57447 () mimi ! kde ! org
[Download RAW message or body]
--===============5129459968539710984==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On 九月 18, 2016, 10:41 a.m., Christoph Feck wrote:
> > I do not understand the bug report you linked to.
> >
> > After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar \
> > because the message text is really long, and after clicking the Details button, \
> > those are correctly shown.
> > What is the actual bug you are trying to fix?
>
> Christoph Feck wrote:
> Sorry, applied repeated() to the wrong string. Now I see the bug.
Hi Christoph,
You are welcome! why say sorry to me ;-)
./tests/kmessageboxtest 14
click 'Details' button, detailsGroup is *NOT* able to show correctly!
I will try to fix as Anthony suggested!
Regards,
Leslie Zhai
- Leslie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99246
-----------------------------------------------------------
On 九月 18, 2016, 10 a.m., Leslie Zhai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> -----------------------------------------------------------
>
> (Updated 九月 18, 2016, 10 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> Hi David,
>
> K3B use KMessageBox::detailedSorry to show message for not support protocol such as \
> add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup \
> https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly \
> by default!
> Regards,
> Leslie Zhai
>
>
> Diffs
> -----
>
> tests/kmessageboxtest.cpp 8ea2848
>
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
>
>
> Testing
> -------
>
> add case 26 in the patch, for long (> 512) details:
>
> kwidgetsaddons/build/tests/kmessageboxtest 26
>
>
> Thanks,
>
> Leslie Zhai
>
>
--===============5129459968539710984==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128768/">https://git.reviewboard.kde.org/r/128768/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On 九月 18th, 2016, 10:41 a.m. CST, <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I do not understand the bug report you linked to.
After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar because \
the message text is really long, and after clicking the Details button, those are \
correctly shown.
What is the actual bug you are trying to fix?</pre>
</blockquote>
<p>On 九月 18th, 2016, 10:44 a.m. CST, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, applied \
repeated() to the wrong string. Now I see the bug.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Christoph,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You are welcome! why say sorry to me ;-)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">./tests/kmessageboxtest 14 click 'Details' button, detailsGroup is <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">NOT</em> able to show correctly! I will try to fix as Anthony suggested!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regards, Leslie Zhai</p></pre>
<br />
<p>- Leslie</p>
<br />
<p>On 九月 18th, 2016, 10 a.m. CST, Leslie Zhai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated 九月 18, 2016, 10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=366569">366569</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi David,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">K3B use \
KMessageBox::detailedSorry to show message for not support protocol such as add files \
from samba, but KMessageBox::detailedSorry hide some part of detailsGroup \
https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly \
by default!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regards, Leslie Zhai</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">add case 26 in the patch, for long (> 512) \
details:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kwidgetsaddons/build/tests/kmessageboxtest \
26</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/kmessageboxtest.cpp <span style="color: grey">(8ea2848)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128768/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5129459968539710984==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic