--===============4303284103670444190== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 ----------------------------------------------------------- Ship it! This is awesome. Ship it. - Vishesh Handa On Sept. 11, 2016, 7:19 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 7:19 p.m.) > > > Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like Query/... > > > Diffs > ----- > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > ------- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > > --===============4303284103670444190== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/

Ship it! 

This is awesome. Ship it.

- Vishesh Handa


On September 11th, 2016, 7:19 p.m. UTC, Christoph Cullmann wrote:

Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa.
By Christoph Cullmann.

Updated Sept. 11, 2016, 7:19 p.m.

Repository: baloo

Description 

At the moment, any application that uses baloo can corrupt the db.
Now, only the things that need to write to it open it with read-write.
This only works as long as the library exposes only read-only things like Query/...

Testing 

Unit tests still work, balooctl seems to do something.

Diffs

  • src/engine/database.h (6ccb2a5)
  • src/engine/database.cpp (6a433c7)
  • src/file/extractor/app.cpp (0ca7276)
  • src/lib/file.cpp (cbbc912)
  • src/lib/searchstore.cpp (060a4fd)
  • src/lib/taglistjob.cpp (76ac8ff)
  • src/qml/experimental/monitor.cpp (11c06ae)
  • src/tools/balooctl/main.cpp (2a6b175)
  • src/tools/balooctl/statuscommand.cpp (1a56c64)
  • src/tools/balooshow/main.cpp (f45f2e0)

View Diff
--===============4303284103670444190==--