[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if w
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-09-08 17:25:05
Message-ID: 20160908172505.5566.79637 () mimi ! kde ! org
[Download RAW message or body]
--===============7810386088888489064==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 8, 2016, 2:16 a.m., Kai Uwe Broulik wrote:
> > src/button.cpp, line 79
> > <https://git.reviewboard.kde.org/r/128856/diff/1/?file=476426#file476426line79>
> >
> > Doesn't this need i18n? Also the wording is a bit technical.
Yes it does. If you have a better idea for wording I'll change that at the same time.
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128856/#review98992
-----------------------------------------------------------
On Sept. 7, 2016, 3:43 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128856/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2016, 3:43 p.m.)
>
>
> Review request for Plasma, Aleix Pol Gonzalez, Kai Uwe Broulik, and David Faure.
>
>
> Bugs: 368240
> https://bugs.kde.org/show_bug.cgi?id=368240
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> This shows a messagebox if ghns dialogs are invoked either by the button or the \
> dialog's exec, open, or show methods if ghns is disabled in kdeglobals (or the \
> applications rc file).
>
> Diffs
> -----
>
> src/button.cpp 1772d86
> src/downloaddialog.h 0a39f5d
> src/downloaddialog.cpp b172e6a
>
> Diff: https://git.reviewboard.kde.org/r/128856/diff/
>
>
> Testing
> -------
>
> Works ok except for the plasma wallpaper case which is doing some strange \
> pointer.data() to set the window title and somehow goes around these checks. Need \
> to figure out why it's doing that and if it's still neeeded there or how to catch \
> those calls to show also.
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============7810386088888489064==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128856/">https://git.reviewboard.kde.org/r/128856/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 8th, 2016, 2:16 a.m. MDT, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128856/diff/1/?file=476426#file476426line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/button.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KMessageBox</span><span class="o">::</span><span \
class="n">information</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="s">"Get Hot New Stuff is disabled by the \
administrator"</span><span class="p">,</span> <span class="s">"Get Hot New \
Stuff disabled"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Doesn't this need i18n? Also the wording is a bit technical.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yes it does. If you have a better idea for wording I'll change that at the \
same time.</p></pre> <br />
<p>- Jeremy</p>
<br />
<p>On September 7th, 2016, 3:43 p.m. MDT, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez, Kai Uwe Broulik, and David \
Faure.</div> <div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2016, 3:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=368240">368240</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This shows a messagebox if ghns dialogs are invoked \
either by the button or the dialog's exec, open, or show methods if ghns is disabled \
in kdeglobals (or the applications rc file).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works ok except for the plasma wallpaper case which is \
doing some strange pointer.data() to set the window title and somehow goes around \
these checks. Need to figure out why it's doing that and if it's still neeeded there \
or how to catch those calls to show also.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/button.cpp <span style="color: grey">(1772d86)</span></li>
<li>src/downloaddialog.h <span style="color: grey">(0a39f5d)</span></li>
<li>src/downloaddialog.cpp <span style="color: grey">(b172e6a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128856/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7810386088888489064==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic