[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126149: [Icon widget] Bring back properties dialog
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-09-06 20:55:57
Message-ID: 20160906205557.5566.62888 () mimi ! kde ! org
[Download RAW message or body]
--===============8764337495306437558==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
-----------------------------------------------------------
(Updated Sept. 6, 2016, 8:55 nachm.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and Plasma.
Bugs: 349177
https://bugs.kde.org/show_bug.cgi?id=349177
Repository: plasma-workspace
Description
-------
This brings back the KPropertiesDialog to modify an icon's appearance. This has been \
requested at multiple occasions. This has been adapted from the Plasma 4 icon code.
Diffs
-----
applets/icon/package/contents/ui/main.qml 9286b94
applets/icon/plugin/icon_p.h dd7963c
applets/icon/plugin/icon_p.cpp e086870
Diff: https://git.reviewboard.kde.org/r/126149/diff/
Testing
-------
Dropped a file from my home onto the desktop -> dialog from the actual file, allowing \
to rename it. The applet reflected the changes.
Dropped an application from kickoff to the desktop -> dialog from a copy of the \
desktop file, allowing to change its icon and description. The applet reflected the \
changes.
Thanks,
Kai Uwe Broulik
--===============8764337495306437558==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126149/">https://git.reviewboard.kde.org/r/126149/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2016, 8:55 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349177">349177</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This brings back the KPropertiesDialog to modify an \
icon's appearance. This has been requested at multiple occasions. This has been \
adapted from the Plasma 4 icon code.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dropped a file from my home onto the desktop -> \
dialog from the actual file, allowing to rename it. The applet reflected the \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dropped an application from kickoff to the desktop \
-> dialog from a copy of the desktop file, allowing to change its icon and \
description. The applet reflected the changes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(9286b94)</span></li>
<li>applets/icon/plugin/icon_p.h <span style="color: grey">(dd7963c)</span></li>
<li>applets/icon/plugin/icon_p.cpp <span style="color: grey">(e086870)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126149/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8764337495306437558==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic