[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128707: Add support for captive portals
From: Lamarque Souza <lamarque () kde ! org>
Date: 2016-09-05 15:47:16
Message-ID: 20160905154716.21849.19071 () mimi ! kde ! org
[Download RAW message or body]
--===============0545639220021172641==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98901
-----------------------------------------------------------
kded/portalmonitor.h (line 22)
<https://git.reviewboard.kde.org/r/128707/#comment66585>
This should go inside if #ifdef section below.
kded/portalmonitor.cpp (line 50)
<https://git.reviewboard.kde.org/r/128707/#comment66586>
I am wondering how hard this waill affect kde.org web server. This patch has the \
potentional to create a DDoS attack-like effect on it. Maybe someone from sysadmin \
should evaluate this.
- Lamarque Souza
On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 12:47 p.m.)
>
>
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
>
>
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. \
> If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive \
> portal), then we open a QWebEngineView trying to load "http://kde.org" page which \
> is supposed to be redirected to the captive portal page. Once user logs in and url \
> changes, we re-check the connectivity again and close the web view if we are no \
> longer behind the captive portal.
>
> Diffs
> -----
>
> CMakeLists.txt a27c1f2
> kded/CMakeLists.txt 1f0613e
> kded/portalmonitor.h PRE-CREATION
> kded/portalmonitor.cpp PRE-CREATION
> kded/service.cpp 18ffd41
>
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
>
>
> Testing
> -------
>
> Tested with three different captive portals and it worked perfectly.
>
>
> Thanks,
>
> Jan Grulich
>
>
--===============0545639220021172641==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128707/">https://git.reviewboard.kde.org/r/128707/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128707/diff/4/?file=474727#file474727line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kded/portalmonitor.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">22</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <QObject></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
should go inside if #ifdef section below.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128707/diff/4/?file=474728#file474728line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kded/portalmonitor.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_view</span><span class="o">-></span><span class="n">setUrl</span><span \
class="p">(</span><span class="n">QUrl</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"http://kde.org"</span><span class="p">)));</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am \
wondering how hard this waill affect kde.org web server. This patch has the \
potentional to create a DDoS attack-like effect on it. Maybe someone from sysadmin \
should evaluate this.</p></pre> </div>
</div>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On August 18th, 2016, 12:47 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Network Management, Plasma, KDE Usability, and Lamarque \
Souza.</div> <div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2016, 12:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=365417">365417</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adds portal monitor to our kded module, which checks \
NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL \
(means we are behind a captive portal), then we open a QWebEngineView trying to load \
"http://kde.org" page which is supposed to be redirected to the captive portal page. \
Once user logs in and url changes, we re-check the connectivity again and close the \
web view if we are no longer behind the captive portal.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with three different captive portals and it \
worked perfectly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a27c1f2)</span></li>
<li>kded/CMakeLists.txt <span style="color: grey">(1f0613e)</span></li>
<li>kded/portalmonitor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/portalmonitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/service.cpp <span style="color: grey">(18ffd41)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128707/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0545639220021172641==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic