[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Accepted] D2645: make sure the vertical systary size hints are fixed
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-09-04 10:24:35
Message-ID: 20160904102434.38184.82544.BC7B989D () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  You don't need to guess, the code is open source...
  
  Here is the reason.
  
  panel/main.qml
  
  the container has:
  
    Layout.preferredHeight: (!currentLayout.isLayoutHorizontal ? (applet && \
applet.Layout.preferredHeight > 0 ? applet.Layout.preferredHeight : root.width) : \
root.height)  
  This means that even though the system tray has no preferredHeight, the container, \
which is what the layout sees does.  The layout will fit an item to fit it's \
preferred height before it will let another item fill height.  
  basically making all trays square if they don't specify anything else.
  
  Put that in the commit message and use you can ship this; though setting the \
preferredHeight is probably more correct.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/systrayvertical

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added a reviewer: davidedmundson.<br />davidedmundson added a comment.<br />This \
revision is now accepted and ready to land.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2645" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>You don&#039;t need to guess, the code is \
open source...</p>

<p>Here is the reason.</p>

<p>panel/main.qml</p>

<p>the container has:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Layout.preferredHeight: \
(!currentLayout.isLayoutHorizontal ? (applet &amp;&amp; applet.Layout.preferredHeight \
&gt; 0 ? applet.Layout.preferredHeight : root.width) : root.height)</pre></div>

<p>This means that even though the system tray has no preferredHeight, the container, \
which is what the layout sees does.  The layout will fit an item to fit it&#039;s \
preferred height before it will let another item fill height.</p>

<p>basically making all trays square if they don&#039;t specify anything else.</p>

<p>Put that in the commit message and use you can ship this; though setting the \
preferredHeight is probably more correct.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>phab/systrayvertical</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2645" \
rel="noreferrer">https://phabricator.kde.org/D2645</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]