[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2645: make sure the vertical systary size hints are fixed
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-09-04 10:06:08
Message-ID: 20160904100608.114736.31755.B28ABD91 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D2645#49268, @davidedmundson wrote:
  
  > Yes I can reproduce the bug. And I even downloaded this and confirm that then i \
can't reproduce it.  >
  > But that doesn't answer my question.
  
  
  the hints of the applet seems sane.
  minimumHeight is the proper size (114 px in my case) preferredHeight -1 (that \
should be ok) and maximumHeight infinity (that should be ok)  but i guess as most \
applets have both min and max defined, the layout decides to stretch this one, as \
it's allowed (since maximum height it's infonite)  i'm surprised that the only one \
that gets stretched isn't the taskbar as is the on.y one to be explicitly fillHeight

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">mart added a comment.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2645" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2645#49268" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D2645#49268</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Yes I can reproduce the bug. And I even \
downloaded this and confirm that then i can&#039;t reproduce it.</p>

<p>But that doesn&#039;t answer my question.</p></div>
</blockquote>

<p>the hints of the applet seems sane.<br />
minimumHeight is the proper size (114 px in my case) preferredHeight -1 (that should \
be ok) and maximumHeight infinity (that should be ok)<br /> but i guess as most \
applets have both min and max defined, the layout decides to stretch this one, as \
it&#039;s allowed (since maximum height it&#039;s infonite)<br /> i&#039;m surprised \
that the only one that gets stretched isn&#039;t the taskbar as is the on.y one to be \
explicitly fillHeight</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2645" \
rel="noreferrer">https://phabricator.kde.org/D2645</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]