[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128808: workspace option kcm rename to tooltip
From: Andreas Kainz <kainz.a () gmail ! com>
Date: 2016-09-03 10:30:40
Message-ID: 20160903103040.21343.39693 () mimi ! kde ! org
[Download RAW message or body]
--===============3593447456314467502==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 1, 2016, 4:59 vorm., Kai Uwe Broulik wrote:
> > -1
> >
> > I was actually planning to add some workspace options (animation speed, OSD \
> > settings, etc) in there.
if you add something, good, but please rename it to something the user can understand \
what the kcm is for. workspace doesn't meen anything specific the global group is \
named workspace.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128808/#review98811
-----------------------------------------------------------
On Sept. 1, 2016, 7:07 vorm., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128808/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2016, 7:07 vorm.)
>
>
> Review request for Plasma, KDE Usability and Heiko Tietze.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> the request rename the workspace kcm (workspace -> desktop behavior -> workspace) \
> to tooltip and move it to the notification section. also the description was \
> changed to desktop tooltips.
> I'm not sure if this kcm exists at the survey from heiko but I don't think so it \
> look like a placeholder kcm where only the tooltip selection was available now so, \
> please rename it to the think you can do and when you add more stuff in the future \
> we can rename it back, but now it's a kcm for turn tooltips on/off.
>
> Diffs
> -----
>
> kcms/workspaceoptions/workspaceoptions.desktop ec1b233
>
> Diff: https://git.reviewboard.kde.org/r/128808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Kainz
>
>
--===============3593447456314467502==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128808/">https://git.reviewboard.kde.org/r/128808/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 1st, 2016, 4:59 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-1
I was actually planning to add some workspace options (animation speed, OSD settings, \
etc) in there.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if \
you add something, good, but please rename it to something the user can understand \
what the kcm is for. workspace doesn't meen anything specific the global group is \
named workspace.</p></pre> <br />
<p>- Andreas</p>
<br />
<p>On September 1st, 2016, 7:07 vorm. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Heiko Tietze.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2016, 7:07 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the request rename the workspace kcm (workspace -> \
desktop behavior -> workspace) to tooltip and move it to the notification section. \
also the description was changed to desktop tooltips.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not sure if this kcm exists at the survey from heiko but I don't think so it look \
like a placeholder kcm where only the tooltip selection was available now so, please \
rename it to the think you can do and when you add more stuff in the future we can \
rename it back, but now it's a kcm for turn tooltips on/off.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/workspaceoptions/workspaceoptions.desktop <span style="color: \
grey">(ec1b233)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128808/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3593447456314467502==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic