[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128707: Add support for captive portals
From: Jan Grulich <jgrulich () redhat ! com>
Date: 2016-09-01 6:36:11
Message-ID: 20160901063611.21343.61859 () mimi ! kde ! org
[Download RAW message or body]
--===============7287814477645065686==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Srp. 31, 2016, 2 odp., Kai Uwe Broulik wrote:
> > I just logged into an airport wifi and although I couldn't access the internet \
> > and was redirected to a login site, NM would *not* detect it as Portal... what am \
> > I missing?
I guess this - https://plus.google.com/u/0/+HonzaGrulich/posts/YmmCsmodYUc
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98809
-----------------------------------------------------------
On Srp. 18, 2016, 12:47 odp., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
>
> (Updated Srp. 18, 2016, 12:47 odp.)
>
>
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
>
>
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. \
> If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive \
> portal), then we open a QWebEngineView trying to load "http://kde.org" page which \
> is supposed to be redirected to the captive portal page. Once user logs in and url \
> changes, we re-check the connectivity again and close the web view if we are no \
> longer behind the captive portal.
>
> Diffs
> -----
>
> CMakeLists.txt a27c1f2
> kded/CMakeLists.txt 1f0613e
> kded/portalmonitor.h PRE-CREATION
> kded/portalmonitor.cpp PRE-CREATION
> kded/service.cpp 18ffd41
>
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
>
>
> Testing
> -------
>
> Tested with three different captive portals and it worked perfectly.
>
>
> Thanks,
>
> Jan Grulich
>
>
--===============7287814477645065686==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128707/">https://git.reviewboard.kde.org/r/128707/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On srpen 31st, 2016, 2 odp. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just logged into an airport wifi and although I \
couldn't access the internet and was redirected to a login site, NM would <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">not</em> detect it as Portal... what am I missing?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
guess this - https://plus.google.com/u/0/+HonzaGrulich/posts/YmmCsmodYUc</p></pre> \
<br />
<p>- Jan</p>
<br />
<p>On srpen 18th, 2016, 12:47 odp. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Network Management, Plasma, KDE Usability, and Lamarque \
Souza.</div> <div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Srp. 18, 2016, 12:47 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=365417">365417</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adds portal monitor to our kded module, which checks \
NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL \
(means we are behind a captive portal), then we open a QWebEngineView trying to load \
"http://kde.org" page which is supposed to be redirected to the captive portal page. \
Once user logs in and url changes, we re-check the connectivity again and close the \
web view if we are no longer behind the captive portal.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with three different captive portals and it \
worked perfectly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a27c1f2)</span></li>
<li>kded/CMakeLists.txt <span style="color: grey">(1f0613e)</span></li>
<li>kded/portalmonitor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/portalmonitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kded/service.cpp <span style="color: grey">(18ffd41)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128707/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7287814477645065686==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic