--===============4083772208255958350== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98809 ----------------------------------------------------------- I just logged into an airport wifi and although I couldn't access the internet and was redirected to a login site, NM would *not* detect it as Portal... what am I missing? - Kai Uwe Broulik On Aug. 18, 2016, 12:47 nachm., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128707/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 12:47 nachm.) > > > Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza. > > > Bugs: 365417 > http://bugs.kde.org/show_bug.cgi?id=365417 > > > Repository: plasma-nm > > > Description > ------- > > Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal. > > > Diffs > ----- > > CMakeLists.txt a27c1f2 > kded/CMakeLists.txt 1f0613e > kded/portalmonitor.h PRE-CREATION > kded/portalmonitor.cpp PRE-CREATION > kded/service.cpp 18ffd41 > > Diff: https://git.reviewboard.kde.org/r/128707/diff/ > > > Testing > ------- > > Tested with three different captive portals and it worked perfectly. > > > Thanks, > > Jan Grulich > > --===============4083772208255958350== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ 

I just logged into an airport wifi and although I couldn't access the internet and was redirected to a login site, NM would not detect it as Portal... what am I missing?

- Kai Uwe Broulik


On August 18th, 2016, 12:47 nachm. UTC, Jan Grulich wrote:

Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
By Jan Grulich.

Updated Aug. 18, 2016, 12:47 nachm.

Bugs: 365417
Repository: plasma-nm

Description 

Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.

Testing 

Tested with three different captive portals and it worked perfectly.

Diffs

  • CMakeLists.txt (a27c1f2)
  • kded/CMakeLists.txt (1f0613e)
  • kded/portalmonitor.h (PRE-CREATION)
  • kded/portalmonitor.cpp (PRE-CREATION)
  • kded/service.cpp (18ffd41)

View Diff
--===============4083772208255958350==--