[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128685: Proofread + update performance kcm docbook
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2016-08-30 20:48:50
Message-ID: 20160830204850.21343.25316 () mimi ! kde ! org
[Download RAW message or body]
--===============1814647522613034275==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 16, 2016, 7:11 vorm., David Faure wrote:
> > Can you move it to kde-baseapps, along with any other konqueror-related docbook?
>
> Burkhard Lück wrote:
> move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, performance, \
> kcmcss, filemanager, khtml-general preserving history from plasma-desktop to \
> kde-baseapps does not make sense, because these docbooks have no history in \
> plasma-desktop besides the initial commit \
> https://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=d64d589db1291fc61935585019f492943ce0032a
> and the history before this commit is hidden and not easy to access.
>
> From my pov these docbook dirs should be copied from kde-runtime (with history) \
> into the directory kde-runtime/doc/kcontrol/ and these dirs should be deleted \
> afterwards in plasma-desktop
> Burkhard Lück wrote:
> - From my pov these docbook dirs should be copied from kde-runtime (with history) \
> into the directory kde-runtime/doc/kcontrol/
> - and these dirs should be deleted afterwards in plasma-desktop
>
> + From my pov these docbook dirs should be copied from kde-runtime (with history) \
> into the directory kde-baseapps/doc/kcontrol/ + and these dirs should be deleted \
> afterwards in plasma-desktop
see https://git.reviewboard.kde.org/r/128803/
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128685/#review98410
-----------------------------------------------------------
On Aug. 15, 2016, 11:48 vorm., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128685/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2016, 11:48 vorm.)
>
>
> Review request for Documentation, KDE Base Apps, Plasma, and David Faure.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> proofread + update
> remove obsolete comment
>
> code in kde-baseapps - docbook in plasma-desktop?
>
>
> Diffs
> -----
>
> doc/kcontrol/performance/index.docbook 5ac5055
>
> Diff: https://git.reviewboard.kde.org/r/128685/diff/
>
>
> Testing
> -------
>
> passes checkXML5
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============1814647522613034275==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128685/">https://git.reviewboard.kde.org/r/128685/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 16th, 2016, 7:11 vorm. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you move it to kde-baseapps, along with any other \
konqueror-related docbook?</p></pre> </blockquote>
<p>On August 17th, 2016, 5:15 nachm. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">move \
khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, performance, kcmcss, \
filemanager, khtml-general preserving history from plasma-desktop to kde-baseapps \
does not make sense, because these docbooks have no history in plasma-desktop besides \
the initial commit https://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=d64d589db1291fc61935585019f492943ce0032a
and the history before this commit is hidden and not easy to access.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">From my pov these docbook dirs should be copied from \
kde-runtime (with history) into the directory kde-runtime/doc/kcontrol/ and these \
dirs should be deleted afterwards in plasma-desktop</p></pre> </blockquote>
<p>On August 18th, 2016, 9:26 vorm. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- From my pov these \
docbook dirs should be copied from kde-runtime (with history) into the directory \
kde-runtime/doc/kcontrol/
- and these dirs should be deleted afterwards in plasma-desktop
+ From my pov these docbook dirs should be copied from kde-runtime (with history) \
into the directory kde-baseapps/doc/kcontrol/ + and these dirs should be deleted \
afterwards in plasma-desktop</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">see \
https://git.reviewboard.kde.org/r/128803/</p></pre> <br />
<p>- Burkhard</p>
<br />
<p>On August 15th, 2016, 11:48 vorm. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Documentation, KDE Base Apps, Plasma, and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2016, 11:48 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">proofread + update remove obsolete comment</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">code in kde-baseapps - docbook in \
plasma-desktop?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">passes checkXML5</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/kcontrol/performance/index.docbook <span style="color: \
grey">(5ac5055)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128685/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1814647522613034275==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic