From kde-panel-devel  Tue Aug 30 16:20:37 2016
From: "wbauer (Wolfgang Bauer)" <noreply () phabricator ! kde ! org>
Date: Tue, 30 Aug 2016 16:20:37 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D2610: Make icon follow styleHints
Message-Id: <20160830162035.22215.38589.F972C000 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147257405120888
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--1b720598894d496ab5f10d6472146c68"

--1b720598894d496ab5f10d6472146c68
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

wbauer added a comment.


  In https://phabricator.kde.org/D2610#48966, @colomar wrote:
  
  > or clicking on a different widget on the desktop might execute an action immediately, which is inconsistent again.
  
  
  It's just that those two are more like (folderview) icons than other widgets.
  
  But ok, I'm fine with that decision too if you think it makes more sense.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2610

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: wbauer, colomar, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--1b720598894d496ab5f10d6472146c68
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">wbauer=20added=20a=20comment.</td><a=20style=3D=
"text-decoration:=20none;=20padding:=204px=208px;=20margin:=200=208px=208px=
;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20bold;=20border-rad=
ius:=203px;=20background-color:=20#F7F7F9;=20background-image:=20linear-gra=
dient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-block;=20border:=201px=
=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabricator.kde.org/D2610=
"=20rel=3D"noreferrer">View=20Revision</a></tr></table><br=20/><div><div><b=
lockquote=20style=3D"border-left:=203px=20solid=20#8C98B8;
=20=20=20=20=20=20=20=20=20=20color:=20#6B748C;
=20=20=20=20=20=20=20=20=20=20font-style:=20italic;
=20=20=20=20=20=20=20=20=20=20margin:=204px=200=2012px=200;
=20=20=20=20=20=20=20=20=20=20padding:=208px=2012px;
=20=20=20=20=20=20=20=20=20=20background-color:=20#F8F9FC;">
<div=20style=3D"font-style:=20normal;
=20=20=20=20=20=20=20=20=20=20padding-bottom:=204px;">In=20<a=20href=3D"htt=
ps://phabricator.kde.org/D2610#48966"=20style=3D"background-color:=20#e7e7e=
7;
=20=20=20=20=20=20=20=20=20=20border-color:=20#e7e7e7;
=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20padding:=200=204px;
=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20color:=20black;text-decoration:=20line-throug=
h;"=20rel=3D"noreferrer">D2610#48966</a>,=20<a=20href=3D"https://phabricato=
r.kde.org/p/colomar/"=20style=3D"
=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20color:=20#19558d;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20background-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border:=201px=20solid=20tra=
nsparent;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20padding:=200=204px;"=20rel=
=3D"noreferrer">@colomar</a>=20wrote:</div>
<div=20style=3D"margin:=200;
=20=20=20=20=20=20=20=20=20=20padding:=200;
=20=20=20=20=20=20=20=20=20=20border:=200;
=20=20=20=20=20=20=20=20=20=20color:=20rgb(107,=20116,=20140);"><p>or=20cli=
cking=20on=20a=20different=20widget=20on=20the=20desktop=20might=20execute=
=20an=20action=20immediately,=20which=20is=20inconsistent=20again.</p></div>
</blockquote>

<p>It&#039;s=20just=20that=20those=20two=20are=20more=20like=20(folderview)=
=20icons=20than=20other=20widgets.</p>

<p>But=20ok,=20I&#039;m=20fine=20with=20that=20decision=20too=20if=20you=20=
think=20it=20makes=20more=20sense.</p></div></div><br=20/><div><strong>REPO=
SITORY</strong><div><div>rPLASMAWORKSPACE=20Plasma=20Workspace</div></div><=
/div><br=20/><div><strong>REVISION=20DETAIL</strong><div><a=20href=3D"https=
://phabricator.kde.org/D2610"=20rel=3D"noreferrer">https://phabricator.kde.=
org/D2610</a></div></div><br=20/><div><strong>EMAIL=20PREFERENCES</strong><=
div><a=20href=3D"https://phabricator.kde.org/settings/panel/emailpreference=
s/"=20rel=3D"noreferrer">https://phabricator.kde.org/settings/panel/emailpr=
eferences/</a></div></div><br=20/><div><strong>To:=20</strong>davidedmundso=
n,=20Plasma,=20mart<br=20/><strong>Cc:=20</strong>wbauer,=20colomar,=20brou=
lik,=20plasma-devel,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abett=
s,=20sebas<br=20/></div>
--1b720598894d496ab5f10d6472146c68--