[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128800: start icon margin update
From: Andreas Kainz <kainz.a () gmail ! com>
Date: 2016-08-30 8:21:52
Message-ID: 20160830082152.21343.20994 () mimi ! kde ! org
[Download RAW message or body]
--===============5033175355291775995==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 30, 2016, 8:06 a.m., Marco Martin wrote:
> > can't download the icon
https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/tasks/start.svgz
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128800/#review98782
-----------------------------------------------------------
On Aug. 29, 2016, 9:24 p.m., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128800/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2016, 9:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> the kde start here icon from the breeze plasma theme should respect the \
> margin/padding of the breeze icon set as all other icons.
> the same layout was any other breeze icon was made (add margin and padding). Didn't \
> change anything on the design.
>
> Diffs
> -----
>
> src/desktoptheme/breeze/icons/start.svgz 5900901
>
> Diff: https://git.reviewboard.kde.org/r/128800/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> final start.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/a91c3252-b9bb-4f8b-aefd-0f42cca0d585__start.svgz
>
>
> Thanks,
>
> Andreas Kainz
>
>
--===============5033175355291775995==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128800/">https://git.reviewboard.kde.org/r/128800/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 30th, 2016, 8:06 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">can't download the icon</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/tasks/start.svgz</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On August 29th, 2016, 9:24 p.m. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2016, 9:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the kde start here icon from the breeze plasma theme \
should respect the margin/padding of the breeze icon set as all other icons.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">the same layout was any other breeze icon was made (add margin and \
padding). Didn't change anything on the design.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/breeze/icons/start.svgz <span style="color: \
grey">(5900901)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128800/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/a91c3252-b9bb-4f8b-aefd-0f42cca0d585__start.svgz">final \
start.svgz file</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5033175355291775995==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic