[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128727: Cursor KCM: fix icon size for the select icon size button
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-08-20 21:07:55
Message-ID: 20160820210755.20316.65713 () mimi ! kde ! org
[Download RAW message or body]

--===============1527060801751855189==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128727/#review98518
-----------------------------------------------------------



This didn't change anyhting for me, the size combo box is still three times as tall \
as the other buttons.

- Kai Uwe Broulik


On Aug. 20, 2016, 8:52 nachm., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128727/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2016, 8:52 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> as the selected icon size was shown top preview the button didn't has to have a \
> different height. 
> 
> Diffs
> -----
> 
> kcms/cursortheme/xcursor/themepage.ui 7e7d365 
> 
> Diff: https://git.reviewboard.kde.org/r/128727/diff/
> 
> 
> Testing
> -------
> 
> didn't compile it.
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
> 


--===============1527060801751855189==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128727/">https://git.reviewboard.kde.org/r/128727/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
didn't change anyhting for me, the size combo box is still three times as tall as the \
other buttons.</p></pre>  <br />









<p>- Kai Uwe Broulik</p>


<br />
<p>On August 20th, 2016, 8:52 nachm. UTC, Andreas Kainz wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Andreas Kainz.</div>


<p style="color: grey;"><i>Updated Aug. 20, 2016, 8:52 nachm.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">as the selected icon size was shown top preview the \
button didn't has to have a different height.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">didn't compile it.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/cursortheme/xcursor/themepage.ui <span style="color: \
grey">(7e7d365)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128727/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1527060801751855189==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic