[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 2 lines] D2322: [Kickoff] Fix start row for drag not always being correct
From:       "net147 (Jonathan Liu)" <noreply () phabricator ! kde ! org>
Date:       2016-08-01 2:02:12
Message-ID: differential-rev-PHID-DREV-jzemycanj6b3d6r2d5uj-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


net147 created this revision.
net147 added reviewers: Plasma, broulik.
net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The start row for the drag is set to the current index but the current index is not \
always the item being dragged. This is because syncTarget has not been called yet to \
update the current index to the item under the cursor. Fix this by calling syncTarget \
before reading the current index.

TEST PLAN
  Drag items around and notice that the item being moved is not always correct.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2322

AFFECTED FILES
  applets/kickoff/package/contents/ui/FavoritesView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: net147, #plasma, broulik
Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">net147 created this revision.<br />net147 added reviewers: \
Plasma, broulik.<br />net147 set the repository for this revision to rPLASMADESKTOP \
Plasma Desktop.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2322" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
start row for the drag is set to the current index but the current index is not \
always the item being dragged. This is because syncTarget has not been called yet to \
update the current index to the item under the cursor. Fix this by calling syncTarget \
before reading the current index.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Drag items around and notice that the item being moved is not \
always correct.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2322" \
rel="noreferrer">https://phabricator.kde.org/D2322</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/kickoff/package/contents/ui/FavoritesView.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>net147, Plasma, broulik<br /><strong>Cc: \
</strong>plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]