From kde-panel-devel Sun Jul 31 15:18:23 2016 From: Eike Hein Date: Sun, 31 Jul 2016 15:18:23 +0000 To: kde-panel-devel Subject: Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualA Message-Id: <20160731151823.20873.76356 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146997831925943 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8585378206589102329==" --===============8585378206589102329== Content-Type: multipart/alternative; boundary="===============8679389636721578172==" --===============8679389636721578172== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/ ----------------------------------------------------------- (Updated July 31, 2016, 3:18 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Marco Martin. Bugs: 366294 http://bugs.kde.org/show_bug.cgi?id=366294 Repository: plasma-framework Description ------- This is done by ContainmentInterface::mousePressEvent, but not in this code path, which is hit for applet panel popups. Folder View relies on this to update actions ahead of the menu being opened. Diffs ----- src/scriptengines/qml/plasmoid/appletinterface.cpp e122db1 Diff: https://git.reviewboard.kde.org/r/128562/diff/ Testing ------- Thanks, Eike Hein --===============8679389636721578172== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128562/

This change has been marked as submitted.

Review request for Plasma and Marco Martin.

By Eike Hein.

Updated July 31, 2016, 3:18 p.m.

Bugs: 366294

Repository: plasma-framework

Description

This is done by ContainmentInterface::mousePressEvent, but not in this code path, which is hit for applet panel popups.

Folder View relies on this to update actions ahead of the menu being opened.

Diffs

src/scriptengines/qml/plasmoid/appletinterface.cpp (e122db1)

View Diff

--===============8679389636721578172==-- --===============8585378206589102329== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8585378206589102329==--