[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid
From: Eike Hein <hein () kde ! org>
Date: 2016-07-31 12:42:58
Message-ID: 20160731124258.20873.88106 () mimi ! kde ! org
[Download RAW message or body]
--===============1099611434434829389==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128552/#review97953
-----------------------------------------------------------
containments/desktop/package/contents/ui/FolderItemDelegate.qml (line 305)
<https://git.reviewboard.kde.org/r/128552/#comment65989>
This approach is kind of wrong because return values of method calls are not \
notifyable props. If the file turns into a symlink or from a symlink into a \
not-symlink, this prop binding will have no way to know. It might work in practice \
because KDirModel will in most cases probably do remove+insert or model resets, but \
it's not correct to write code against this assumptions.
My advice is whether the KDirModel::Type model column correctly identifies \
symlinks as such, then add a new bool data role IsSymlink or similar to FolderModel \
and use that in the view code.
- Eike Hein
On July 29, 2016, 3:40 p.m., Chinmoy Ranjan Pradhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128552/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 3:40 p.m.)
>
>
> Review request for Plasma, Kai Uwe Broulik, Bhushan Shah, and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> In folder view plasmoid symlinks and ordinary files look similar. This patch makes \
> the symlink look different by italicising its name and adding an icon overlay.
>
> Diffs
> -----
>
> containments/desktop/package/contents/ui/FolderItemDelegate.qml e4fcd67
> containments/desktop/plugins/folder/CMakeLists.txt 1095f81
> containments/desktop/plugins/folder/foldermodel.h a6992bb
> containments/desktop/plugins/folder/foldermodel.cpp 2b9d41b
>
> Diff: https://git.reviewboard.kde.org/r/128552/diff/
>
>
> Testing
> -------
>
> build
>
>
> File Attachments
> ----------------
>
> symlinks and other files/folders look similar
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png
> after patch , everything looks fine
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png
>
>
> Thanks,
>
> Chinmoy Ranjan Pradhan
>
>
--===============1099611434434829389==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128552/">https://git.reviewboard.kde.org/r/128552/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128552/diff/2/?file=472574#file472574line305" \
style="color: black; font-weight: bold; text-decoration: \
underline;">containments/desktop/package/contents/ui/FolderItemDelegate.qml</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">305</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">font.italic:</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
approach is kind of wrong because return values of method calls are not notifyable \
props. If the file turns into a symlink or from a symlink into a not-symlink, this \
prop binding will have no way to know. It might work in practice because KDirModel \
will in most cases probably do remove+insert or model resets, but it's not correct to \
write code against this assumptions.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">My advice is whether \
the KDirModel::Type model column correctly identifies symlinks as such, then add a \
new bool data role IsSymlink or similar to FolderModel and use that in the view \
code.</p></pre> </div>
</div>
<br />
<p>- Eike Hein</p>
<br />
<p>On July 29th, 2016, 3:40 p.m. UTC, Chinmoy Ranjan Pradhan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik, Bhushan Shah, and Eike Hein.</div>
<div>By Chinmoy Ranjan Pradhan.</div>
<p style="color: grey;"><i>Updated July 29, 2016, 3:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In folder view plasmoid symlinks and ordinary files \
look similar. This patch makes the symlink look different by italicising its name and \
adding an icon overlay.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">build</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/desktop/package/contents/ui/FolderItemDelegate.qml <span \
style="color: grey">(e4fcd67)</span></li>
<li>containments/desktop/plugins/folder/CMakeLists.txt <span style="color: \
grey">(1095f81)</span></li>
<li>containments/desktop/plugins/folder/foldermodel.h <span style="color: \
grey">(a6992bb)</span></li>
<li>containments/desktop/plugins/folder/foldermodel.cpp <span style="color: \
grey">(2b9d41b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128552/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png">symlinks \
and other files/folders look similar</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png">after \
patch , everything looks fine</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1099611434434829389==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic