[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 128562: Emit contextualActionsAboutToShow before showing the applet's contextualA
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-07-31 12:14:42
Message-ID: 20160731121442.20873.29585 () mimi ! kde ! org
[Download RAW message or body]
--===============5565018368355989877==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128562/#review97949
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On July 31, 2016, 12:13 p.m., Eike Hein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128562/
> -----------------------------------------------------------
>
> (Updated July 31, 2016, 12:13 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Bugs: 366294
> http://bugs.kde.org/show_bug.cgi?id=366294
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This is done by ContainmentInterface::mousePressEvent, but not in this code path, \
> which is hit for applet panel popups.
> Folder View relies on this to update actions ahead of the menu being opened.
>
>
> Diffs
> -----
>
> src/scriptengines/qml/plasmoid/appletinterface.cpp e122db1
>
> Diff: https://git.reviewboard.kde.org/r/128562/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eike Hein
>
>
--===============5565018368355989877==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128562/">https://git.reviewboard.kde.org/r/128562/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Edmundson</p>
<br />
<p>On July 31st, 2016, 12:13 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated July 31, 2016, 12:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=366294">366294</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is done by ContainmentInterface::mousePressEvent, \
but not in this code path, which is hit for applet panel popups.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Folder View relies on this to update actions ahead of the menu being \
opened.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(e122db1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128562/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5565018368355989877==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic