'Re: Review Request 128557: Folder View Plasmoid: Undo trash'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128557: Folder View Plasmoid: Undo trash
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-07-30 13:02:54
Message-ID: 20160730130254.21373.14302 () mimi ! kde ! org
[Download RAW message or body]

--===============8542893451396616183==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128557/#review97922
-----------------------------------------------------------

Shouldn't KIO TrashJob take care of that automatically?

- Kai Uwe Broulik

On Juli 30, 2016, 12:59 nachm., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128557/
> -----------------------------------------------------------
> 
> (Updated Juli 30, 2016, 12:59 nachm.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Bhushan Shah, and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> In folder view plasmoid one can't undo a trash job.
> This patch adds the support for undoing trash job.
> 
> 
> Diffs
> -----
> 
> containments/desktop/plugins/folder/foldermodel.cpp ed73f86 
> 
> Diff: https://git.reviewboard.kde.org/r/128557/diff/
> 
> 
> Testing
> -------
> 
> build
> Deleted file from folder view
> Got it back with 'undo trash'
> 
> 
> File Attachments
> ----------------
> 
> undo trash
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/30/b51fcfd7-9968-46d1-aec9-449a2db23df7__undo-trash.png
>  
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
> 

--===============8542893451396616183==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128557/">https://git.reviewboard.kde.org/r/128557/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Shouldn't KIO TrashJob take care of that automatically?</p></pre>  <br />

<p>- Kai Uwe Broulik</p>

<br />
<p>On Juli 30th, 2016, 12:59 nachm. UTC, Chinmoy Ranjan Pradhan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Kai Uwe Broulik, Bhushan Shah, and Eike Hein.</div>
<div>By Chinmoy Ranjan Pradhan.</div>

<p style="color: grey;"><i>Updated Juli 30, 2016, 12:59 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In folder view plasmoid one can't undo a trash job. \
This patch adds the support for undoing trash job.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">build Deleted file from folder view
Got it back with 'undo trash'</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containments/desktop/plugins/folder/foldermodel.cpp <span style="color: \
grey">(ed73f86)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128557/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/30/b51fcfd7-9968-46d1-aec9-449a2db23df7__undo-trash.png">undo \
trash</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8542893451396616183==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 