[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage
From:       "apol (Aleix Pol Gonzalez)" <noreply () phabricator ! kde ! org>
Date:       2016-07-29 14:14:47
Message-ID: 20160729141445.128719.51666.CFDCCF06 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


apol added a comment.


  In https://phabricator.kde.org/D2306#43024, @mart wrote:
  
  > it should just be a fixed header, always visible and laid out with the main \
content or flickable, it should be in Page (and just happening to work in \
scrollablepage too) and the property called just header, not pageHeader  >
  > ie it has to be as much identical as possible to 
  >  http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html
  >
  > because Page is going to inherit from that one in the future
  
  
  I'm not sure that's what I need. Should I implement it in Discover and when we move \
to Qt 5.7 we see what should be upstreamed, if anything?

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2306

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel


[Attachment #5 (text/html)]

<table><tr><td style="">apol added a comment.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2306" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2306#43024" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D2306#43024</a>, <a \
href="https://phabricator.kde.org/p/mart/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@mart</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>it should just be a fixed header, always \
visible and laid out with the main content or flickable, it should be in Page (and \
just happening to work in scrollablepage too) and the property called just header, \
not pageHeader</p>

<p>ie it has to be as much identical as possible to <br />
 <a href="http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html" \
class="remarkup-link" target="_blank" \
rel="noreferrer">http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html</a></p>

<p>because Page is going to inherit from that one in the future</p></div>
</blockquote>

<p>I&#039;m not sure that&#039;s what I need. Should I implement it in Discover and \
when we move to Qt 5.7 we see what should be upstreamed, if \
anything?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKIRIGAMI \
Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2306" \
rel="noreferrer">https://phabricator.kde.org/D2306</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart<br /><strong>Cc: \
</strong>plasma-devel<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]