From kde-panel-devel Fri Jul 29 13:57:26 2016 From: Marco Martin Date: Fri, 29 Jul 2016 13:57:26 +0000 To: kde-panel-devel Subject: Re: Review Request 128551: [TextFieldStyle] Calculate right padding with clear button properly Message-Id: <20160729135726.21373.43558 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146980066424690 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8619640772172757119==" --===============8619640772172757119== Content-Type: multipart/alternative; boundary="===============7273131143672813326==" --===============7273131143672813326== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128551/#review97907 ----------------------------------------------------------- Ship it! Ship It! - Marco Martin On July 29, 2016, 12:21 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128551/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 12:21 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This is probably a copy-paste error as the close button's height is "parent.height * 0.8" and in a style you usually prepend "control." to everything but basing the padding on the TextField's *parent* makes no sense. While at it, fixed coding style. > > > Diffs > ----- > > src/declarativeimports/plasmastyle/TextFieldStyle.qml 05ff3d5 > > Diff: https://git.reviewboard.kde.org/r/128551/diff/ > > > Testing > ------- > > Fixes the filter box in eg. KTP quick chat applet having an insanely huge right padding > > > Thanks, > > Kai Uwe Broulik > > --===============7273131143672813326== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128551/

Ship it!

Ship It!

- Marco Martin

On July 29th, 2016, 12:21 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.

By Kai Uwe Broulik.

Updated July 29, 2016, 12:21 p.m.

Repository: plasma-framework

Description

This is probably a copy-paste error as the close button's height is "parent.height * 0.8" and in a style you usually prepend "control." to everything but basing the padding on the TextField's parent makes no sense. While at it, fixed coding style.

Testing

Fixes the filter box in eg. KTP quick chat applet having an insanely huge right padding

Diffs

src/declarativeimports/plasmastyle/TextFieldStyle.qml (05ff3d5)

View Diff

--===============7273131143672813326==-- --===============8619640772172757119== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8619640772172757119==--