From kde-panel-devel Fri Jul 29 13:42:33 2016 From: Kai Uwe Broulik Date: Fri, 29 Jul 2016 13:42:33 +0000 To: kde-panel-devel Subject: Re: Review Request 128550: [TextField] Bind to TextField length instead of text Message-Id: <20160729134233.21373.26366 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146979977024451 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9186543331503120282==" --===============9186543331503120282== Content-Type: multipart/alternative; boundary="===============2489971088706766936==" --===============2489971088706766936== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128550/ ----------------------------------------------------------- (Updated July 29, 2016, 1:42 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 42193ae6312be533d464f49c989776a3257d3caa by Kai Uwe Broulik to branch master. Repository: plasma-framework Description ------- Copying strings in QML is expensive. Diffs ----- src/declarativeimports/plasmacomponents/qml/TextField.qml c027add Diff: https://git.reviewboard.kde.org/r/128550/diff/ Testing ------- As per documentation "This property can be faster than querying the length of the text property as it doesn't require any copying or conversion of the TextField's internal string data." Button still works as expected Thanks, Kai Uwe Broulik --===============2489971088706766936== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128550/

This change has been marked as submitted.

Review request for Plasma.

By Kai Uwe Broulik.

Updated July 29, 2016, 1:42 p.m.

Changes

Submitted with commit 42193ae6312be533d464f49c989776a3257d3caa by Kai Uwe Broulik to branch master.

Repository: plasma-framework

Description

Copying strings in QML is expensive.

Testing

As per documentation "This property can be faster than querying the length of the text property as it doesn't require any copying or conversion of the TextField's internal string data."

Button still works as expected

Diffs

src/declarativeimports/plasmacomponents/qml/TextField.qml (c027add)

View Diff

--===============2489971088706766936==-- --===============9186543331503120282== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============9186543331503120282==--